ARROW-4179: [Python] Use more public API to determine whether a test has a pytest mark or not#3333
Closed
wesm wants to merge 1 commit intoapache:masterfrom
Closed
ARROW-4179: [Python] Use more public API to determine whether a test has a pytest mark or not#3333wesm wants to merge 1 commit intoapache:masterfrom
wesm wants to merge 1 commit intoapache:masterfrom
Conversation
…behavior of item.obj changed Change-Id: I2230b5013e56f4e123fac33c07cf7f0692631282
Member
|
Triggered crossbow conda and wheel tests too (don't need to wait though). |
Codecov Report
@@ Coverage Diff @@
## master #3333 +/- ##
===========================================
- Coverage 87.71% 68.43% -19.29%
===========================================
Files 449 373 -76
Lines 53077 48578 -4499
===========================================
- Hits 46557 33243 -13314
- Misses 6411 15335 +8924
+ Partials 109 0 -109
Continue to review full report at Codecov.
|
kszucs
approved these changes
Jan 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was an internal API change in pytest 4.1.0 that resulted in our pytest configuration logic failing to check if marks were set or not on unit tests. I confirmed that the following fixes the problem both on pytest 4.0.x (where things still worked) and 4.1.0 (when things broke)