Skip to content

ARROW-4179: [Python] Use more public API to determine whether a test has a pytest mark or not #3333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wesm wants to merge 1 commit into from
Closed

ARROW-4179: [Python] Use more public API to determine whether a test has a pytest mark or not #3333

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions python/pyarrow/tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,8 @@ def pytest_collection_modifyitems(config, items):
def pytest_runtest_setup(item):
only_set = False

item_marks = {mark.name: mark for mark in item.iter_markers()}

for group in groups:
flag = '--{0}'.format(group)
only_flag = '--only-{0}'.format(group)
Expand All @@ -154,7 +156,7 @@ def pytest_runtest_setup(item):

if item.config.getoption(only_flag):
only_set = True
elif getattr(item.obj, group, None):
elif group in item_marks:
is_enabled = (item.config.getoption(flag) or
item.config.getoption(enable_flag))
is_disabled = item.config.getoption(disable_flag)
Expand All @@ -165,8 +167,7 @@ def pytest_runtest_setup(item):
skip_item = True
for group in groups:
only_flag = '--only-{0}'.format(group)
if (getattr(item.obj, group, False) and
item.config.getoption(only_flag)):
if group in item_marks and item.config.getoption(only_flag):
skip_item = False

if skip_item:
Expand Down