GH-42193: [Java] Update dependency to maintain JUnit 5 only by llama90 · Pull Request #42206 · apache/arrow

llama90 · 2024-06-19T03:40:38Z

Rationale for this change

We have completed migrating all unit test code from JUnit 4 to JUnit 5 for all Java modules. Now, we are removing the compatibility library junit-vintage-engine to maintain JUnit 5 only.

What changes are included in this PR?

Removing JUnit 4 dependencies
Updating remaining junit.framework.TestCase imports
Updating excludes to prevent JUnit 4 dependencies

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

GitHub Issue: [Java] Remove JUnit 4 Dependencies after JUnit 5 upgrade #42193

llama90 · 2024-06-19T04:00:16Z

@vibhatha Is it sufficient to just remove the junit-vintage-engine dependency?

Also, I encountered an error after merging my Flight Module commit as below. However, the current machine was not used to migrate the Flight Module. The machine has a tricky environment, so I cannot be sure if the error is occurring for everyone.

However, the CIs seem to be working well.

[ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.026 s <<< FAILURE! -- in org.apache.arrow.driver.jdbc.ITDriverJarValidation
[ERROR] org.apache.arrow.driver.jdbc.ITDriverJarValidation.validateShadedJar -- Time elapsed: 0.011 s <<< FAILURE!
org.opentest4j.AssertionFailedError: jar ==> expected: <Driver jar was not detected in the classpath> but was: <jar>
        at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
        at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
        at org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197)
        at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182)
        at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1156)
        at org.apache.arrow.driver.jdbc.ITDriverJarValidation.getJdbcJarFile(ITDriverJarValidation.java:72)
        at org.apache.arrow.driver.jdbc.ITDriverJarValidation.validateShadedJar(ITDriverJarValidation.java:84)
        at java.base/java.lang.reflect.Method.invoke(Method.java:580)
        at java.base/java.util.ArrayList.forEach(ArrayList.java:1597)
        at java.base/java.util.ArrayList.forEach(ArrayList.java:1597)

[INFO] 
[INFO] Results:
[INFO] 
[ERROR] Failures: 
[ERROR]   ITDriverJarValidation.validateShadedJar:84->getJdbcJarFile:72 jar ==> expected: <Driver jar was not detected in the classpath> but was: <jar>
[INFO] 
[ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0

vibhatha · 2024-06-19T06:42:30Z

I also got the same error locally when I was testing some other feature. We may need to take a look. Could you file an issue?

vibhatha · 2024-06-19T06:43:12Z

Also I am not sure if that would be the only dependency. Can we try intellisense and see if we still get the Junit4?

llama90 · 2024-06-19T08:28:36Z

Also I am not sure if that would be the only dependency. Can we try intellisense and see if we still get the Junit4?

We can check the dependencies using mvn dependency.

There are no JUnit 4.x dependencies.

So, I believe there is no need for further checks.

I attached result.

 mvn dependency:tree | grep junit 
[INFO] +- org.junit.jupiter:junit-jupiter-engine:jar:5.10.2:test
[INFO] |  +- org.junit.platform:junit-platform-engine:jar:1.10.2:test
[INFO] +- org.junit.jupiter:junit-jupiter-api:jar:5.10.2:test
[INFO] |  \- org.junit.platform:junit-platform-commons:jar:1.10.2:test
[INFO] +- org.junit.jupiter:junit-jupiter-params:jar:5.10.2:test
[INFO] +- org.mockito:mockito-junit-jupiter:jar:2.25.1:test
[INFO] +- org.junit.jupiter:junit-jupiter-engine:jar:5.10.2:test
[INFO] |  +- org.junit.platform:junit-platform-engine:jar:1.10.2:test
[INFO] +- org.junit.jupiter:junit-jupiter-api:jar:5.10.2:test
[INFO] |  \- org.junit.platform:junit-platform-commons:jar:1.10.2:test
[INFO] +- org.junit.jupiter:junit-jupiter-params:jar:5.10.2:test
[INFO] +- org.mockito:mockito-junit-jupiter:jar:2.25.1:test
[INFO] +- org.junit.jupiter:junit-jupiter-engine:jar:5.10.2:test
[INFO] |  +- org.junit.platform:junit-platform-engine:jar:1.10.2:test
[INFO] +- org.junit.jupiter:junit-jupiter-api:jar:5.10.2:test
[INFO] |  \- org.junit.platform:junit-platform-commons:jar:1.10.2:test
[INFO] +- org.junit.jupiter:junit-jupiter-params:jar:5.10.2:test
[INFO] +- org.mockito:mockito-junit-jupiter:jar:2.25.1:test
[INFO] +- org.junit.jupiter:junit-jupiter-engine:jar:5.10.2:test
[INFO] |  +- org.junit.platform:junit-platform-engine:jar:1.10.2:test
[INFO] +- org.junit.jupiter:junit-jupiter-api:jar:5.10.2:test
[INFO] |  \- org.junit.platform:junit-platform-commons:jar:1.10.2:test
[INFO] +- org.junit.jupiter:junit-jupiter-params:jar:5.10.2:test
[INFO] +- org.mockito:mockito-junit-jupiter:jar:2.25.1:test
[INFO] +- org.junit.jupiter:junit-jupiter-engine:jar:5.10.2:test
[INFO] |  +- org.junit.platform:junit-platform-engine:jar:1.10.2:test
[INFO] +- org.junit.jupiter:junit-jupiter-api:jar:5.10.2:test
[INFO] |  \- org.junit.platform:junit-platform-commons:jar:1.10.2:test
[INFO] +- org.junit.jupiter:junit-jupiter-params:jar:5.10.2:test
[INFO] +- org.mockito:mockito-junit-jupiter:jar:2.25.1:test
[INFO] +- org.junit.jupiter:junit-jupiter-engine:jar:5.10.2:test
[INFO] |  +- org.junit.platform:junit-platform-engine:jar:1.10.2:test
[INFO] +- org.junit.jupiter:junit-jupiter-api:jar:5.10.2:test
[INFO] |  \- org.junit.platform:junit-platform-commons:jar:1.10.2:test
[INFO] +- org.junit.jupiter:junit-jupiter-params:jar:5.10.2:test
[INFO] +- org.mockito:mockito-junit-jupiter:jar:2.25.1:test
[INFO] +- org.junit.jupiter:junit-jupiter-engine:jar:5.10.2:test
[INFO] |  +- org.junit.platform:junit-platform-engine:jar:1.10.2:test
[INFO] +- org.junit.jupiter:junit-jupiter-api:jar:5.10.2:test
[INFO] |  \- org.junit.platform:junit-platform-commons:jar:1.10.2:test
[INFO] +- org.junit.jupiter:junit-jupiter-params:jar:5.10.2:test
[INFO] +- org.mockito:mockito-junit-jupiter:jar:2.25.1:test
[INFO] +- org.junit.jupiter:junit-jupiter-engine:jar:5.10.2:test
[INFO] |  +- org.junit.platform:junit-platform-engine:jar:1.10.2:test
[INFO] +- org.junit.jupiter:junit-jupiter-api:jar:5.10.2:test
[INFO] |  \- org.junit.platform:junit-platform-commons:jar:1.10.2:test
[INFO] +- org.junit.jupiter:junit-jupiter-params:jar:5.10.2:test
[INFO] +- org.mockito:mockito-junit-jupiter:jar:2.25.1:test
[INFO] +- org.junit.jupiter:junit-jupiter-engine:jar:5.10.2:test
[INFO] |  +- org.junit.platform:junit-platform-engine:jar:1.10.2:test
[INFO] +- org.junit.jupiter:junit-jupiter-api:jar:5.10.2:test
[INFO] |  \- org.junit.platform:junit-platform-commons:jar:1.10.2:test
[INFO] +- org.junit.jupiter:junit-jupiter-params:jar:5.10.2:test
[INFO] +- org.mockito:mockito-junit-jupiter:jar:2.25.1:test
[INFO] +- org.junit.jupiter:junit-jupiter-engine:jar:5.10.2:test
[INFO] |  +- org.junit.platform:junit-platform-engine:jar:1.10.2:test
[INFO] +- org.junit.jupiter:junit-jupiter-api:jar:5.10.2:test
[INFO] |  \- org.junit.platform:junit-platform-commons:jar:1.10.2:test
[INFO] +- org.junit.jupiter:junit-jupiter-params:jar:5.10.2:test
[INFO] +- org.mockito:mockito-junit-jupiter:jar:2.25.1:test
[INFO] +- org.junit.jupiter:junit-jupiter-engine:jar:5.10.2:test
[INFO] |  +- org.junit.platform:junit-platform-engine:jar:1.10.2:test
[INFO] +- org.junit.jupiter:junit-jupiter-api:jar:5.10.2:test
[INFO] |  \- org.junit.platform:junit-platform-commons:jar:1.10.2:test
[INFO] +- org.junit.jupiter:junit-jupiter-params:jar:5.10.2:test
[INFO] +- org.mockito:mockito-junit-jupiter:jar:2.25.1:test
[INFO] +- org.junit.jupiter:junit-jupiter-engine:jar:5.10.2:test
[INFO] |  +- org.junit.platform:junit-platform-engine:jar:1.10.2:test
[INFO] +- org.junit.jupiter:junit-jupiter-api:jar:5.10.2:test
[INFO] |  \- org.junit.platform:junit-platform-commons:jar:1.10.2:test
[INFO] +- org.junit.jupiter:junit-jupiter-params:jar:5.10.2:test
[INFO] +- org.mockito:mockito-junit-jupiter:jar:2.25.1:test
[INFO] +- org.junit.jupiter:junit-jupiter-engine:jar:5.10.2:test
[INFO] |  +- org.junit.platform:junit-platform-engine:jar:1.10.2:test
[INFO] +- org.junit.jupiter:junit-jupiter-api:jar:5.10.2:test
[INFO] |  \- org.junit.platform:junit-platform-commons:jar:1.10.2:test
[INFO] +- org.junit.jupiter:junit-jupiter-params:jar:5.10.2:test
[INFO] +- org.mockito:mockito-junit-jupiter:jar:2.25.1:test
[INFO] +- org.junit.jupiter:junit-jupiter-engine:jar:5.10.2:test
[INFO] |  +- org.junit.platform:junit-platform-engine:jar:1.10.2:test
[INFO] +- org.junit.jupiter:junit-jupiter-api:jar:5.10.2:test
[INFO] |  \- org.junit.platform:junit-platform-commons:jar:1.10.2:test
[INFO] +- org.junit.jupiter:junit-jupiter-params:jar:5.10.2:test
[INFO] +- org.mockito:mockito-junit-jupiter:jar:2.25.1:test
[INFO] +- org.junit.jupiter:junit-jupiter-engine:jar:5.10.2:test
[INFO] |  +- org.junit.platform:junit-platform-engine:jar:1.10.2:test
[INFO] +- org.junit.jupiter:junit-jupiter-api:jar:5.10.2:test
[INFO] |  \- org.junit.platform:junit-platform-commons:jar:1.10.2:test
[INFO] +- org.junit.jupiter:junit-jupiter-params:jar:5.10.2:test
[INFO] +- org.mockito:mockito-junit-jupiter:jar:2.25.1:test
[INFO] +- org.junit.jupiter:junit-jupiter-engine:jar:5.10.2:test
[INFO] |  +- org.junit.platform:junit-platform-engine:jar:1.10.2:test
[INFO] +- org.junit.jupiter:junit-jupiter-api:jar:5.10.2:test
[INFO] |  \- org.junit.platform:junit-platform-commons:jar:1.10.2:test
[INFO] +- org.junit.jupiter:junit-jupiter-params:jar:5.10.2:test
[INFO] +- org.mockito:mockito-junit-jupiter:jar:2.25.1:test
[INFO] +- org.junit.jupiter:junit-jupiter-engine:jar:5.10.2:test
[INFO] |  +- org.junit.platform:junit-platform-engine:jar:1.10.2:test
[INFO] +- org.junit.jupiter:junit-jupiter-api:jar:5.10.2:test
[INFO] |  \- org.junit.platform:junit-platform-commons:jar:1.10.2:test
[INFO] +- org.junit.jupiter:junit-jupiter-params:jar:5.10.2:test
[INFO] +- org.mockito:mockito-junit-jupiter:jar:2.25.1:test
[INFO] +- org.junit.jupiter:junit-jupiter-engine:jar:5.10.2:test
[INFO] |  +- org.junit.platform:junit-platform-engine:jar:1.10.2:test
[INFO] +- org.junit.jupiter:junit-jupiter-api:jar:5.10.2:test
[INFO] |  \- org.junit.platform:junit-platform-commons:jar:1.10.2:test
[INFO] +- org.junit.jupiter:junit-jupiter-params:jar:5.10.2:test
[INFO] +- org.mockito:mockito-junit-jupiter:jar:2.25.1:test
[INFO] +- org.junit.jupiter:junit-jupiter-engine:jar:5.10.2:test
[INFO] |  +- org.junit.platform:junit-platform-engine:jar:1.10.2:test
[INFO] +- org.junit.jupiter:junit-jupiter-api:jar:5.10.2:test
[INFO] |  \- org.junit.platform:junit-platform-commons:jar:1.10.2:test
[INFO] +- org.junit.jupiter:junit-jupiter-params:jar:5.10.2:test
[INFO] +- org.mockito:mockito-junit-jupiter:jar:2.25.1:test
[INFO] +- org.junit.jupiter:junit-jupiter-engine:jar:5.10.2:test
[INFO] |  +- org.junit.platform:junit-platform-engine:jar:1.10.2:test
[INFO] +- org.junit.jupiter:junit-jupiter-api:jar:5.10.2:test
[INFO] |  \- org.junit.platform:junit-platform-commons:jar:1.10.2:test
[INFO] +- org.junit.jupiter:junit-jupiter-params:jar:5.10.2:test
[INFO] +- org.mockito:mockito-junit-jupiter:jar:2.25.1:test

llama90 · 2024-06-19T08:31:22Z

I also got the same error locally when I was testing some other feature. We may need to take a look. Could you file an issue?

That's right. The issue appears intermittently. I'll summarize the details and create an issue.

lidavidm · 2024-06-19T08:49:12Z

I believe we have a way to configure disallowed dependencies for a stronger check

lidavidm · 2024-06-19T08:49:57Z

Ah, the root POM has maven-enforcer-plugin which can ban junit4 entirely

vibhatha · 2024-06-19T08:54:16Z

maven-enforcer-plugin

I took a look, we already listed a few such dependencies. That's perfect. Let's use that.

llama90 · 2024-06-19T09:11:25Z

I updated it. Thank you for review!

lidavidm · 2024-06-19T09:16:45Z

@github-actions crossbow submit -g java

github-actions · 2024-06-19T09:19:10Z

Revision: be5e51a73ec8e3aef318a4a3c85fe892d3a9ad26

Submitted crossbow builds: ursacomputing/crossbow @ actions-cc74f066f5

Task	Status
java-jars
test-conda-python-3.10-spark-v3.5.0
test-conda-python-3.11-spark-master
test-conda-python-3.8-spark-v3.5.0
verify-rc-source-java-linux-almalinux-8-amd64
verify-rc-source-java-linux-conda-latest-amd64
verify-rc-source-java-linux-ubuntu-20.04-amd64
verify-rc-source-java-linux-ubuntu-22.04-amd64
verify-rc-source-java-macos-amd64

llama90 · 2024-06-19T09:49:45Z

I also got the same error locally when I was testing some other feature. We may need to take a look. Could you file an issue?

I created issue for comment

[Java] Intermittent Test Failure in flight-sql-jdbc-driver Module #42208

lidavidm · 2024-06-19T23:05:44Z

just making sure java-jars passes now

vibhatha · 2024-06-19T23:36:49Z

Did we re-run?

lidavidm · 2024-06-19T23:49:32Z

@vibhatha can someone take a look at the issue? I don't think this will go away on re-run

vibhatha · 2024-06-20T00:14:37Z

@lidavidm I think @kou resolved this issue here: #42197
Probably need a rebase?

llama90 · 2024-06-20T00:20:44Z

That was rebased about two hours ago. Perhaps we could try running it again?

vibhatha · 2024-06-20T00:36:11Z

@github-actions crossbow submit java-jars

github-actions · 2024-06-20T00:38:23Z

Revision: f41f9b7285b189060e90fcd870d9608fec9cbe54

Submitted crossbow builds: ursacomputing/crossbow @ actions-5074156199

Task	Status
java-jars

vibhatha · 2024-06-20T01:38:26Z

@llama90 I think now we are failing at the issue we recently filed: #42208

lidavidm · 2024-06-21T04:04:07Z

@llama90 if you want to rebase here I can re-run Crossbow

llama90 · 2024-06-21T04:07:37Z

@lidavidm Done!

lidavidm · 2024-06-21T04:08:58Z

@github-actions crossbow submit -g java

github-actions · 2024-06-21T04:11:14Z

Revision: 4db3a9f

Submitted crossbow builds: ursacomputing/crossbow @ actions-4efa92c4b0

Task	Status
java-jars
test-conda-python-3.10-spark-v3.5.0
test-conda-python-3.11-spark-master
test-conda-python-3.8-spark-v3.5.0
verify-rc-source-java-linux-almalinux-8-amd64
verify-rc-source-java-linux-conda-latest-amd64
verify-rc-source-java-linux-ubuntu-20.04-amd64
verify-rc-source-java-linux-ubuntu-22.04-amd64
verify-rc-source-java-macos-amd64

conbench-apache-arrow · 2024-06-21T14:31:08Z

After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit f07d442.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 10 possible false positives for unstable benchmarks that are known to sometimes produce them.

…ache#42206) ### Rationale for this change We have completed migrating all unit test code from JUnit 4 to JUnit 5 for all Java modules. Now, we are removing the compatibility library `junit-vintage-engine` to maintain JUnit 5 only. ### What changes are included in this PR? - Removing JUnit 4 dependencies - Updating remaining `junit.framework.TestCase` imports - Updating excludes to prevent JUnit 4 dependencies ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: apache#42193 Authored-by: Hyunseok Seo <hsseo0501@gmail.com> Signed-off-by: David Li <li.davidm96@gmail.com>

llama90 requested a review from lidavidm as a code owner June 19, 2024 03:40

github-actions Bot added Component: Java awaiting review Awaiting review labels Jun 19, 2024

llama90 commented Jun 19, 2024

View reviewed changes

github-actions Bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Jun 19, 2024

llama90 changed the title ~~GH-42193: [Java] Remove junit-vintage-engine dependency to maintain JUnit 5 only~~ GH-42193: [Java] Update dependency to maintain JUnit 5 only Jun 19, 2024

llama90 force-pushed the ARROW-42193 branch from be5e51a to f41f9b7 Compare June 19, 2024 21:37

lidavidm approved these changes Jun 19, 2024

View reviewed changes

github-actions Bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Jun 19, 2024

vibhatha approved these changes Jun 19, 2024

View reviewed changes

llama90 added 4 commits June 21, 2024 13:06

remove junit-vintage-engine dependency to prevent using JUnit 4

a106eb3

update junit.framework.TestCase imports

3ca7fdc

remove junit 4.13.2 dependency to prevent using JUnit 4

ce168d4

update excludes to prevent junit dependencies

4db3a9f

llama90 force-pushed the ARROW-42193 branch from f41f9b7 to 4db3a9f Compare June 21, 2024 04:06

lidavidm approved these changes Jun 21, 2024

View reviewed changes

lidavidm merged commit f07d442 into apache:main Jun 21, 2024

lidavidm removed the awaiting merge Awaiting merge label Jun 21, 2024

github-actions Bot added the awaiting merge Awaiting merge label Jun 21, 2024

vibhatha mentioned this pull request Jun 21, 2024

[Java] Remove JUnit 4 Dependencies after JUnit 5 upgrade #42193

Closed

Uh oh!

Conversation

llama90 commented Jun 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Uh oh!

llama90 commented Jun 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vibhatha commented Jun 19, 2024

Uh oh!

vibhatha commented Jun 19, 2024

Uh oh!

llama90 commented Jun 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

llama90 commented Jun 19, 2024

Uh oh!

lidavidm commented Jun 19, 2024

Uh oh!

lidavidm commented Jun 19, 2024

Uh oh!

vibhatha commented Jun 19, 2024

Uh oh!

llama90 Jun 19, 2024

Choose a reason for hiding this comment

Uh oh!

lidavidm commented Jun 19, 2024

Uh oh!

github-actions Bot commented Jun 19, 2024

Uh oh!

llama90 commented Jun 19, 2024

Uh oh!

lidavidm commented Jun 19, 2024

Uh oh!

vibhatha commented Jun 19, 2024

Uh oh!

lidavidm commented Jun 19, 2024

Uh oh!

vibhatha commented Jun 20, 2024

Uh oh!

llama90 commented Jun 20, 2024

Uh oh!

vibhatha commented Jun 20, 2024

Uh oh!

github-actions Bot commented Jun 20, 2024

Uh oh!

vibhatha commented Jun 20, 2024

Uh oh!

lidavidm commented Jun 21, 2024

Uh oh!

llama90 commented Jun 21, 2024

Uh oh!

lidavidm commented Jun 21, 2024

Uh oh!

github-actions Bot commented Jun 21, 2024

Uh oh!

conbench-apache-arrow Bot commented Jun 21, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

llama90 commented Jun 19, 2024 •

edited

Loading

llama90 commented Jun 19, 2024 •

edited

Loading

llama90 commented Jun 19, 2024 •

edited

Loading