ARROW-5513: [Java] Refactor method name for getstartOffset to use camel case - #4475
Closed
liyafan82 wants to merge 3 commits into
Closed
ARROW-5513: [Java] Refactor method name for getstartOffset to use camel case#4475liyafan82 wants to merge 3 commits into
liyafan82 wants to merge 3 commits into
Conversation
liyafan82
changed the title
praveenbingo
requested changes
Jun 5, 2019
praveenbingo
left a comment
praveenbingo
left a comment
Contributor
There was a problem hiding this comment.
This will break all code that extends this class - can we please not do this? Or at-least introduce a new method and mark the other one as deprecated.
Contributor
Author
@praveenbingo Thanks for the suggestion. I have preserved the old method and made it deprecated. |
praveenbingo
reviewed
Jun 6, 2019
praveenbingo
approved these changes
Jun 6, 2019
praveenbingo
left a comment
praveenbingo
left a comment
Contributor
There was a problem hiding this comment.
Thanks @liyafan82. Please go ahead and merge after the minor name fix.
Contributor
|
+1 LGTM. |
pribor
pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
…el case The method getstartOffset in class org.apache.arrow.vector.BaseVariableWidthVector should be refactored to getStartOffset, to comply with the camel case. Fortunately, this method is not public, so the changes are internal to Arrow. Author: liyafan82 <fan_li_ya@foxmail.com> Closes apache#4475 from liyafan82/fly_0605_start and squashes the following commits: 6c2c333 <liyafan82> Fix javadoc d0b57be <liyafan82> Preserve the old method and make it deprecated 919bb3d <liyafan82> Refactor method name for getstartOffset to use camel case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The method getstartOffset in class org.apache.arrow.vector.BaseVariableWidthVector should be refactored to getStartOffset, to comply with the camel case.
Fortunately, this method is not public, so the changes are internal to Arrow.