ARROW-5500: [R] read_csv_arrow() signature should match readr::read_csv()#4711
ARROW-5500: [R] read_csv_arrow() signature should match readr::read_csv()#4711nealrichardson wants to merge 5 commits into
Conversation
wesm
left a comment
wesm
left a comment
There was a problem hiding this comment.
Haven't looked carefully at the R code (could @romainfrancois take a look)? But I found the version number in NEWS.md to be misleading, since a CRAN release probably won't happen until after 0.14.0 goes out
| under the License. | ||
| --> | ||
|
|
||
| # arrow 0.13.0.9000 |
There was a problem hiding this comment.
It should. https://issues.apache.org/jira/browse/ARROW-5415 will update it to the release version in dev/release/00-prepare.sh. I have a branch for that based on this one.
There was a problem hiding this comment.
…ing readr::read_csv arguments
nealrichardson
force-pushed
the
readr-csv
branch
from
95fea1d to
92b0a27
Compare
|
Here's a passing Travis build: https://travis-ci.org/nealrichardson/arrow/builds/551482949 Appveyor running here: https://ci.appveyor.com/project/nealrichardson/arrow/builds/25596580. Will wait a bit yet |
|
The R Appveyor build is running now so I'll merge once that passes |
|
Build is passed |
In previous patches, I removed other places where the version was explicitly referenced, making them parse it from `r/DESCRIPTION` where necessary. The only remaining one (added by #4711) is `r/NEWS.md`, and it works a little differently when bumping from a release version to a dev version. So from dev to release, we go from e.g. ``` # arrow 0.13.0.9000 * Stuff we did in this release * More stuff ``` to ``` # arrow 0.14.0 * Stuff we did in this release * More stuff ``` but when bumping after release for the next dev version, it goes to ``` # arrow 0.14.0.9000 # arrow 0.14.0 * Stuff we did in this release * More stuff ``` so that we have a place to accumulate the list of changes in the next release. Author: Neal Richardson <neal.p.richardson@gmail.com> Author: Sutou Kouhei <kou@clear-code.com> Closes #4727 from nealrichardson/r-version-update and squashes the following commits: f3dfa66 <Sutou Kouhei> Use for consistency 1ae324f <Neal Richardson> Review feedback 090e3a5 <Neal Richardson> Update r/NEWS.md with release or new dev version
2 participants
This patch enumerates the various CSV parsing options and exposes them in an R-familiar way in the signature of
read_csv_arrow(). It also adds a genericread_delim_arrow()for providing other delimiting characters, as well as aread_tsv_arrow(). In the process, I identified some limitations of the current reader (https://issues.apache.org/jira/browse/ARROW-5747) and of the R bindings to it (not yet ticketed), and added more docs and tests.Other release-prep cleanup in here includes organization of the DESCRIPTION file, adding new functions to the pkgdown config, and adding a NEWS.md.