ARROW-5415: [Release] Release script should update R version everywhere#4727
ARROW-5415: [Release] Release script should update R version everywhere#4727nealrichardson wants to merge 3 commits into
Conversation
|
Here's a passing Travis build for the lint/release test job: https://travis-ci.org/nealrichardson/arrow/jobs/551443590 |
kou
left a comment
kou
left a comment
There was a problem hiding this comment.
I'm not sure changes except dev/release/ and r/NEWS.md should be included this "Release script should update R version everywhere" pull request.
(Normally, I don't want to include...)
There was a problem hiding this comment.
Could you use [ ${type} = "snapshot" ] here?
There was a problem hiding this comment.
Could you use #{@release_version}.9000 here?
There was a problem hiding this comment.
Oops, yes, will do.
|
Once #4711 merges I'll push a cleaned up branch; just wanted to make the change visible for review now (and thanks for the review). |
Codecov Report
@@ Coverage Diff @@
## master #4727 +/- ##
=========================================
Coverage ? 75.68%
=========================================
Files ? 58
Lines ? 3735
Branches ? 0
=========================================
Hits ? 2827
Misses ? 908
Partials ? 0
Continue to review full report at Codecov.
|
|
This can be rebased now |
* Update r/NEWS.md version in release prep script * Replace only the first match in r/NEWS.md * For post-release, add an entry to r/NEWS.md
nealrichardson
force-pushed
the
r-version-update
branch
from
d6f19af to
1ae324f
Compare
|
Rebased and the lint/release job passed on my Travis: https://travis-ci.org/nealrichardson/arrow/jobs/551551770 |
kou
left a comment
kou
left a comment
There was a problem hiding this comment.
+1
I've pushed a commit to use [ ... ] instead of [[ ... ]] for consistency.
We can merge this when CI is green.
4 participants
In previous patches, I removed other places where the version was explicitly referenced, making them parse it from
r/DESCRIPTIONwhere necessary. The only remaining one (added by #4711) isr/NEWS.md, and it works a little differently when bumping from a release version to a dev version. So from dev to release, we go from e.g.to
but when bumping after release for the next dev version, it goes to
so that we have a place to accumulate the list of changes in the next release.