Skip to content

ARROW-5753: [Rust] Fix test failure in CI code coverage#4748

Closed
sunchao wants to merge 2 commits intoapache:masterfrom
sunchao:ARROW-5753
Closed

ARROW-5753: [Rust] Fix test failure in CI code coverage#4748
sunchao wants to merge 2 commits intoapache:masterfrom
sunchao:ARROW-5753

Conversation

@sunchao
Copy link
Member

@sunchao sunchao commented Jun 29, 2019

No description provided.

@codecov-io
Copy link

codecov-io commented Jun 29, 2019

Codecov Report

Merging #4748 into master will increase coverage by 0.9%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #4748     +/-   ##
=========================================
+ Coverage   86.44%   87.34%   +0.9%     
=========================================
  Files         992      992             
  Lines      138020   138020             
  Branches     1418     1418             
=========================================
+ Hits       119311   120559   +1248     
+ Misses      18347    17099   -1248     
  Partials      362      362
Impacted Files Coverage Δ
rust/parquet/src/util/test_common/file_util.rs 76.66% <0%> (-20%) ⬇️
cpp/src/arrow/csv/column-builder.cc 95.29% <0%> (-1.77%) ⬇️
cpp/src/plasma/thirdparty/ae/ae.c 70.75% <0%> (-0.95%) ⬇️
rust/arrow/src/array/array.rs 93.26% <0%> (+0.2%) ⬆️
rust/arrow/src/datatypes.rs 78.63% <0%> (+0.27%) ⬆️
rust/parquet/src/arrow/schema.rs 86.39% <0%> (+0.31%) ⬆️
rust/arrow/src/csv/reader.rs 86.29% <0%> (+2.04%) ⬆️
rust/arrow/src/compute/array_ops.rs 98.12% <0%> (+3.75%) ⬆️
rust/datafusion/src/logicalplan.rs 52.06% <0%> (+5.37%) ⬆️
rust/datafusion/src/sql/planner.rs 74.91% <0%> (+6%) ⬆️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d25902...f66d0bf. Read the comment docs.

@sunchao sunchao marked this pull request as ready for review July 1, 2019 20:01
@sunchao
Copy link
Member Author

sunchao commented Jul 1, 2019

@fsaintjacques @andygrove @nevi-me : could you take a look?

Copy link
Contributor

@nevi-me nevi-me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@kszucs kszucs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kszucs kszucs closed this in 4b09ae3 Jul 2, 2019
kou pushed a commit that referenced this pull request Jul 4, 2019
Author: Chao Sun <sunchao@apache.org>

Closes #4748 from sunchao/ARROW-5753 and squashes the following commits:

f66d0bf <Chao Sun> Remove warnings in rustfmt
4a22e6b <Chao Sun> ARROW-5753:  Fix test failure in CI code coverage
kszucs pushed a commit that referenced this pull request Jul 22, 2019
Author: Chao Sun <sunchao@apache.org>

Closes #4748 from sunchao/ARROW-5753 and squashes the following commits:

f66d0bf <Chao Sun> Remove warnings in rustfmt
4a22e6b <Chao Sun> ARROW-5753:  Fix test failure in CI code coverage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants