GH-48941: [C++] Generate proper UTF-8 strings in JSON test utilities #48943
+72
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
pitrou
reviewed
Jan 26, 2026
Comment on lines
+181
to
183
| // Using c_str() is safe here because generation excludes U+0000 (no embedded nulls). | ||
| // U+0000 can only exist in plane 0 (BMP), and BMP generation starts at U+0020. | ||
| return OK(writer.String(s.c_str())); |
Member
There was a problem hiding this comment.
I think we can just call writer.String(s) actually.
github-actions
bot
added
awaiting committer review
pitrou
reviewed
Jan 26, 2026
Member
pitrou
left a comment
pitrou
left a comment
There was a problem hiding this comment.
Was there a particular concern around this that led you to submit this PR?
In any case, I think it might be worth having a more generic helper in arrow/testing/random.h or anything. Something like:
std::string RandomUtf8String(int num_chars);
Member
Author
|
There was a todo Let me take a look at the suggestion. I am also happy with just removing this TODO out if that doesn't sound quite worthwhile .. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The JSON test utility
GenerateAsciiwas only generating ASCII characters. Should better have the test coverage for proper UTF-8 and Unicode handling.What changes are included in this PR?
Replaced ASCII-only generation with proper UTF-8 string generation that produces valid Unicode scalar values across all planes (BMP, SMP, SIP, planes 3-16), correctly encoded per RFC 3629.
Are these changes tested?
There are existent tests for JSON.
Are there any user-facing changes?
No, test-only.