ARROW-6035: [Java] Avro adapter support convert nullable value - #4943
Closed
tianchen92 wants to merge 7 commits into
Closed
ARROW-6035: [Java] Avro adapter support convert nullable value#4943tianchen92 wants to merge 7 commits into
tianchen92 wants to merge 7 commits into
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4943 +/- ##
==========================================
+ Coverage 87.48% 89.72% +2.23%
==========================================
Files 994 667 -327
Lines 140683 98284 -42399
Branches 1418 0 -1418
==========================================
- Hits 123074 88181 -34893
+ Misses 17247 10103 -7144
+ Partials 362 0 -362
Continue to review full report at Codecov.
|
emkornfield
reviewed
Jul 26, 2019
emkornfield
reviewed
Jul 26, 2019
emkornfield
reviewed
Jul 26, 2019
emkornfield
reviewed
Jul 26, 2019
added 4 commits
July 29, 2019 16:52
Contributor
|
Sorry, will take a look tomorrow at the updates. |
emkornfield
requested changes
Jul 30, 2019
emkornfield
left a comment
emkornfield
left a comment
Contributor
There was a problem hiding this comment.
Looks much nicer with delegation. Thank you. Still a few more points that need to be addressed.
added 2 commits
July 31, 2019 10:19
Contributor
Author
|
@emkornfield Build passed, I think we could get this merged :) |
Contributor
|
yep. +1, thank you. |
pribor
pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
Related to [ARROW-6035](https://issues.apache.org/jira/browse/ARROW-6035). A specific Avro unions type(has two types and one is null type) could convert to a nullable ArrowVector. For instance, ["null", "string"] could represented by a VarcharVector which could has null value. Closes apache#4943 from tianchen92/ARROW-6035 and squashes the following commits: 8af1bfe <tianchen> rename be18c56 <tianchen> resolve comments 0e7adda <tianchen> fix writer 42979b7 <tianchen> fix 2cc3950 <tianchen> fix nullable check 92fb616 <tianchen> resolve comments ffaa138 <tianchen> ARROW-6035: Avro adapter support convert nullable value Authored-by: tianchen <niki.lj@alibaba-inc.com> Signed-off-by: Micah Kornfield <emkornfield@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to ARROW-6035.
A specific Avro unions type(has two types and one is null type) could convert to a nullable ArrowVector.
For instance, ["null", "string"] could represented by a VarcharVector which could has null value.