GH-50302: [GLib][Ruby][FlightRPC] Fix GC related problems by kou · Pull Request #50401 · apache/arrow

kou · 2026-07-07T00:49:39Z

Rationale for this change

gaflight_server_listen() may use options' auth handler later. So we should refer the given options while the server is alive. If we don't refer the given options, we may touch freed auth handler later.

The argument of ArrowFlight::Criteria.new/ArrowFlight::Ticket.new should be referred to protect from GC in Ruby.

I could fix some problems by GC.stress = true but I couldn't fix some problems that are reproduced only on GitHub Actions. I omit tests for them for now.

What changes are included in this PR?

Refer options for gaflight_server_listen()
Refer expression for ArrowFlight::Criteria.new
Refer data for ArrowFlight::Ticket.new
Omit Flight related tests that I can't fix...

Are these changes tested?

Yes.

Are there any user-facing changes?

Yes.

GitHub Issue: [GLib][Ruby] ci/scripts/c_glib_test.sh fails consistently on new macos-26-arm64 #50302

github-actions · 2026-07-07T00:50:05Z

⚠️ GitHub issue #50302 has been automatically assigned in GitHub to PR creator.

Copilot

Pull request overview

This PR updates the GLib Arrow Flight server binding to retain a reference to the GAFlightServerOptions passed to gaflight_server_listen(), preventing the options (and indirectly the auth handler object graph) from being freed while the server is still alive.

Changes:

Store GAFlightServerOptions* in GAFlightServerPrivate and keep it referenced across the server lifetime.
Add a dispose implementation to release the stored options reference when the server object is torn down.
Update gaflight_server_listen() to replace the stored options reference on each listen.

+  auto priv = GAFLIGHT_SERVER_GET_PRIVATE(server);
+  if (priv->options) {
+    g_object_unref(priv->options);
+  }
+  priv->options = options;
+  g_object_ref(priv->options);


Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

+  if (priv->options) {
+    g_object_unref(priv->options);
+    priv->options = nullptr;
+  }


+  auto priv = GAFLIGHT_SERVER_GET_PRIVATE(server);
+  if (priv->options != options) {
+    g_object_ref(priv->options);
+    if (priv->options) {
+      g_object_unref(priv->options);
+    }
+    priv->options = options;
+  }


Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

+  if (priv->options) {
+    g_object_unref(priv->options);
+    priv->options = nullptr;
+  }
+


  macos:
    name: ARM64 macOS GLib & Ruby
-    runs-on: macos-latest
+    runs-on: macos-26
    if: ${{ !contains(github.event.pull_request.title, 'WIP') }}


Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

+  auto priv = GAFLIGHT_SERVER_GET_PRIVATE(object);
+
+  if (priv->options) {
+    g_object_unref(priv->options);
+    priv->options = nullptr;
+  }


+env | sort
+
+run_test_args=()
+if [ -n "${RUNNER_DEBUG}" ]; then
+  run_test_args+=(-v)
+fi
+ruby test/run-test.rb "${run_test_args[@]}"


  macos:
    name: ARM64 macOS GLib & Ruby
-    runs-on: macos-latest
+    runs-on: macos-26
    if: ${{ !contains(github.event.pull_request.title, 'WIP') }}


Copilot

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.

Copilot

Pull request overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated 3 comments.

    omit("Arrow Flight is required") unless defined?(ArrowFlight)
    omit("Unstable on Windows") if Gem.win_platform?
-    omit("Unstable on x86_64 macOS") if /x86_64-darwin/.match?(RUBY_PLATFORM)
+    omit("Unstable on macOS") if /darwin/.match?(RUBY_PLATFORM)
    require_gi_bindings(3, 4, 7)


+module ArrowFlight
+  class Criteria
+    alias_method :initialize_raw, :initialize
+    def initialize(expression)
+      initialize_raw(expression)
+      @expression = expression
+    end
+  end


  def test_data
    data = "data"
-    ticket = ArrowFlight::Ticket.new(data)
+    data_bytes = GLib::Bytes.new(data)
+    ticket = ArrowFlight::Ticket.new(data_bytes)
    assert_equal(data,
                 ticket.data.to_s)
  end


Copilot

Pull request overview

Copilot reviewed 20 out of 20 changed files in this pull request and generated 2 comments.

    omit("Arrow Flight is required") unless defined?(ArrowFlight)
    omit("Unstable on Windows") if Gem.win_platform?
-    omit("Unstable on x86_64 macOS") if /x86_64-darwin/.match?(RUBY_PLATFORM)
+    omit("Unstable on macOS") if /darwin/.match?(RUBY_PLATFORM)
    require_gi_bindings(3, 4, 7)


    @server = nil
    omit("Unstable on Windows") if Gem.win_platform?
+    omit("Unstable on macOS") if /darwin/.match?(RUBY_PLATFORM)
    @server = Helper::Server.new


Copilot

Pull request overview

Copilot reviewed 21 out of 21 changed files in this pull request and generated 6 comments.

+    alias_method :initialize_raw, :initialize
+    def initialize(data)


+    alias_method :initialize_raw, :initialize
+    def initialize(expression)


    data = "data"
-    ticket = ArrowFlight::Ticket.new(data)
+    data_bytes = GLib::Bytes.new(data)
+    ticket = ArrowFlight::Ticket.new(data_bytes)
    assert_equal(data,


    expression = "expression"
-    criteria = ArrowFlight::Criteria.new(expression)
+    expression_bytes = GLib::Bytes.new(expression)
+    criteria = ArrowFlight::Criteria.new(expression_bytes)
    assert_equal(expression,


  macos:
    name: ARM64 macOS GLib & Ruby
-    runs-on: macos-latest
+    runs-on: macos-26
    if: ${{ !contains(github.event.pull_request.title, 'WIP') }}


    omit("Arrow Flight is required") unless defined?(ArrowFlight)
    omit("Unstable on Windows") if Gem.win_platform?
-    omit("Unstable on x86_64 macOS") if /x86_64-darwin/.match?(RUBY_PLATFORM)
+    omit("Unstable on macOS") if /darwin/.match?(RUBY_PLATFORM)


Copilot

Pull request overview

Copilot reviewed 20 out of 20 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

c_glib/arrow-flight-glib/server.cpp:1249

GAFlightServerPrivate::options is never initialized in gaflight_server_init(). The code currently relies on instance-private memory being zeroed; if that assumption changes, dispose/get_property may read or unref a garbage pointer. Initialize it explicitly when constructing the instance.

static void
gaflight_server_init(GAFlightServer *object)
{
  auto priv = GAFLIGHT_SERVER_GET_PRIVATE(object);
  new (&(priv->server)) gaflight::Server(object);
}

… `gaflight_server_listen()` `gaflight_server_listen()` may use options' auth handler later. So we should refer the given options while the server is alive.

Copilot

Pull request overview

Copilot reviewed 20 out of 20 changed files in this pull request and generated 1 comment.

    omit("Arrow Flight is required") unless defined?(ArrowFlight)
    omit("Unstable on Windows") if Gem.win_platform?
-    omit("Unstable on x86_64 macOS") if /x86_64-darwin/.match?(RUBY_PLATFORM)
+    omit("Unstable on macOS") if /darwin/.match?(RUBY_PLATFORM)


kou · 2026-07-09T00:38:12Z

+1

Copilot AI review requested due to automatic review settings July 7, 2026 00:49

Copilot started reviewing on behalf of kou July 7, 2026 00:50 View session

github-actions Bot added Component: GLib awaiting committer review Awaiting committer review labels Jul 7, 2026

Copilot AI reviewed Jul 7, 2026

View reviewed changes

Comment thread c_glib/arrow-flight-glib/server.cpp Outdated

Comment on lines +1254 to +1259

auto priv = GAFLIGHT_SERVER_GET_PRIVATE(server);

if (priv->options) {

g_object_unref(priv->options);

}

priv->options = options;

g_object_ref(priv->options);

kou force-pushed the glib-flight-listen-gc branch from 3b0771c to 3df3a78 Compare July 7, 2026 01:03

kou requested review from assignUser, jonkeane and raulcd as code owners July 7, 2026 01:03

Copilot AI review requested due to automatic review settings July 7, 2026 01:24

kou force-pushed the glib-flight-listen-gc branch from 3df3a78 to 8f41f6b Compare July 7, 2026 01:24

Copilot started reviewing on behalf of kou July 7, 2026 01:25 View session

Copilot AI reviewed Jul 7, 2026

View reviewed changes

kou force-pushed the glib-flight-listen-gc branch from 8f41f6b to 853822b Compare July 7, 2026 01:36

Copilot AI review requested due to automatic review settings July 7, 2026 01:45

kou force-pushed the glib-flight-listen-gc branch from 853822b to 8239181 Compare July 7, 2026 01:45

Copilot started reviewing on behalf of kou July 7, 2026 01:47 View session

Copilot AI reviewed Jul 7, 2026

View reviewed changes

kou force-pushed the glib-flight-listen-gc branch from 8239181 to df02f37 Compare July 7, 2026 04:44

kou changed the title ~~GH-50302: [GLib][FlightRPC] Add a missing options reference for gaflight_server_listen()~~ GH-50302: [GLib][Ruby][FlightRPC] Add missing references for GC Jul 7, 2026

github-actions Bot added the Component: Ruby label Jul 7, 2026

Copilot AI review requested due to automatic review settings July 7, 2026 06:10

kou force-pushed the glib-flight-listen-gc branch from df02f37 to 632f010 Compare July 7, 2026 06:10

Copilot started reviewing on behalf of kou July 7, 2026 06:11 View session

Copilot AI reviewed Jul 7, 2026

View reviewed changes

kou force-pushed the glib-flight-listen-gc branch 2 times, most recently from eab1c4a to e5960c4 Compare July 7, 2026 06:52

Copilot AI review requested due to automatic review settings July 7, 2026 06:52

Copilot AI reviewed Jul 7, 2026

View reviewed changes

kou force-pushed the glib-flight-listen-gc branch from 1306697 to 1201244 Compare July 7, 2026 23:57

Copilot AI review requested due to automatic review settings July 7, 2026 23:57

github-actions Bot added Component: Parquet Component: Gandiva labels Jul 7, 2026

Copilot started reviewing on behalf of kou July 7, 2026 23:58 View session

Copilot AI reviewed Jul 8, 2026

View reviewed changes

kou force-pushed the glib-flight-listen-gc branch from 1201244 to 63e8f97 Compare July 8, 2026 00:21

Copilot AI review requested due to automatic review settings July 8, 2026 05:05

kou force-pushed the glib-flight-listen-gc branch from 63e8f97 to f675c66 Compare July 8, 2026 05:05

Copilot started reviewing on behalf of kou July 8, 2026 05:06 View session

Copilot AI reviewed Jul 8, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings July 8, 2026 05:57

kou force-pushed the glib-flight-listen-gc branch from f675c66 to 8670d78 Compare July 8, 2026 05:57

Copilot started reviewing on behalf of kou July 8, 2026 05:57 View session

Copilot AI reviewed Jul 8, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings July 8, 2026 08:42

kou force-pushed the glib-flight-listen-gc branch from 8670d78 to 7ff0901 Compare July 8, 2026 08:42

Copilot started reviewing on behalf of kou July 8, 2026 08:42 View session

Copilot AI reviewed Jul 8, 2026

View reviewed changes

apacheGH-50302: [GLib][FlightRPC] Add a missing options reference for…

dba843b

… `gaflight_server_listen()` `gaflight_server_listen()` may use options' auth handler later. So we should refer the given options while the server is alive.

Copilot AI review requested due to automatic review settings July 8, 2026 12:37

kou force-pushed the glib-flight-listen-gc branch from 7ff0901 to dba843b Compare July 8, 2026 12:37

Copilot started reviewing on behalf of kou July 8, 2026 12:37 View session

Copilot AI reviewed Jul 8, 2026

View reviewed changes

Comment thread c_glib/test/flight/test-client.rb

omit("Arrow Flight is required") unless defined?(ArrowFlight)

omit("Unstable on Windows") if Gem.win_platform?

omit("Unstable on x86_64 macOS") if /x86_64-darwin/.match?(RUBY_PLATFORM)

omit("Unstable on macOS") if /darwin/.match?(RUBY_PLATFORM)

kou changed the title ~~GH-50302: [GLib][Ruby][FlightRPC] Add missing references for GC~~ GH-50302: [GLib][Ruby][FlightRPC] Fix GC related problems Jul 9, 2026

kou merged commit 463682d into apache:main Jul 9, 2026
54 checks passed

kou removed the awaiting committer review Awaiting committer review label Jul 9, 2026

kou deleted the glib-flight-listen-gc branch July 9, 2026 00:38

kou mentioned this pull request Jul 9, 2026

[GLib][Ruby] ci/scripts/c_glib_test.sh fails consistently on new macos-26-arm64 #50302

Closed

		alias_method :initialize_raw, :initialize
		def initialize(data)

		alias_method :initialize_raw, :initialize
		def initialize(expression)

Uh oh!

Conversation

kou commented Jul 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Uh oh!

github-actions Bot commented Jul 7, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

kou commented Jul 9, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

kou commented Jul 7, 2026 •

edited

Loading