GH-50457: [C++][Gandiva] Add LN alias for LOG#50458
Open
lriggs wants to merge 3 commits into
Open
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
LNis the standard SQL name for the natural logarithm, while Gandiva exposes it aslog. Addinglnas an alias lets SQL engines that emitLN(x)route to the same precompiledlog_<type>functions without duplicating any C code. The alias mechanism already exists in Gandiva and is used forpow(alias ofpower),trunc(alias oftruncate), andudfdegrees(alias ofdegrees).What changes are included in this PR?
NativeFunctionaccepts abase_nameand astd::vector<std::string> aliases. Each alias gets its ownFunctionSignaturethat points to the same precompiled (pc_name) function — soln_int32does not need to exist; the alias"ln"resolves to the same IR symbollog_int32.The
MATH_UNARY_OPS(name, ALIASES)macro infunction_registry_math_ops.ccexpands to sixNativeFunctionentries (int32, int64, uint32, uint64, float32, float64), all forwarding to the correspondinglog_<type>precompiled symbols.Are these changes tested?
New unit tests.
Are there any user-facing changes?
Yes, a new Gandiva function.