Skip to content

ARROW-6205: [C++] ARROW_DEPRECATED warning when including io/interfaces.h #5062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
harrism wants to merge 3 commits into from
Closed

ARROW-6205: [C++] ARROW_DEPRECATED warning when including io/interfaces.h #5062

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6143b46
When compiling with nvcc, don't use ARROW_DEPRECATED on using statement
harrism Aug 12, 2019
b129d56
fix preprocessor macro logic
harrism Aug 12, 2019
f4d89b3
remove deprecated aliases in interfaces.h
harrism Aug 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions cpp/src/arrow/io/interfaces.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,16 +190,6 @@ class ARROW_EXPORT ReadWriteFileInterface : public RandomAccessFile, public Writ
ReadWriteFileInterface() { RandomAccessFile::set_mode(FileMode::READWRITE); }
};

// TODO(kszucs): remove this after 0.13
#ifndef _MSC_VER
using WriteableFile ARROW_DEPRECATED("Use WritableFile") = WritableFile;
using ReadableFileInterface ARROW_DEPRECATED("Use RandomAccessFile") = RandomAccessFile;
#else
// MSVC does not like using ARROW_DEPRECATED with using declarations
using WriteableFile = WritableFile;
using ReadableFileInterface = RandomAccessFile;
#endif

} // namespace io
} // namespace arrow

Expand Down