GH-50766: [CI][Dev] Fix shellcheck errors in the ci/scripts/r_docker_configure.sh

[hiroyuki-sato]

Rationale for this change

This is the sub issue #44748.

• SC2006 (style): Use $(...) notation instead of legacy backticks
• SC2046: Quote this to prevent word splitting.
• SC2086: Double quote to prevent globbing and word splitting.
• SC2223: This default assignment may cause DoS due to globbing. Quote it.

shellcheck ci/scripts/r_docker_configure.sh

In ci/scripts/r_docker_configure.sh line 21:
: ${R_BIN:=R}
  ^---------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.


In ci/scripts/r_docker_configure.sh line 23:
: ${ARROW_SOURCE_HOME:=/arrow}
  ^--------------------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.


In ci/scripts/r_docker_configure.sh line 29:
  cat ${ARROW_SOURCE_HOME}/ci/etc/rprofile >> $(${R_BIN} RHOME)/etc/Rprofile.site
      ^------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                              ^---------------^ SC2046 (warning): Quote this to prevent word splitting.

Did you mean:
  cat "${ARROW_SOURCE_HOME}"/ci/etc/rprofile >> $(${R_BIN} RHOME)/etc/Rprofile.site


In ci/scripts/r_docker_configure.sh line 33:
echo "MAKEFLAGS=-j$(${R_BIN} -s -e 'cat(parallel::detectCores())')" >> $(R RHOME)/etc/Renviron.site
                                                                       ^--------^ SC2046 (warning): Quote this to prevent word splitting.


In ci/scripts/r_docker_configure.sh line 36:
if [ "`which dnf`" ]; then
      ^---------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`.

Did you mean:
if [ "$(which dnf)" ]; then


In ci/scripts/r_docker_configure.sh line 38:
elif [ "`which yum`" ]; then
        ^---------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`.

Did you mean:
elif [ "$(which yum)" ]; then


In ci/scripts/r_docker_configure.sh line 40:
elif [ "`which zypper`" ]; then
        ^------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`.

Did you mean:
elif [ "$(which zypper)" ]; then


In ci/scripts/r_docker_configure.sh line 42:
elif [ "`which apk`" ]; then
        ^---------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`.

Did you mean:
elif [ "$(which apk)" ]; then


In ci/scripts/r_docker_configure.sh line 50:
: ${R_CUSTOM_CCACHE:=FALSE}
  ^-----------------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.


In ci/scripts/r_docker_configure.sh line 51:
R_CUSTOM_CCACHE=`echo $R_CUSTOM_CCACHE | tr '[:upper:]' '[:lower:]'`
                ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
                      ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
R_CUSTOM_CCACHE=$(echo "$R_CUSTOM_CCACHE" | tr '[:upper:]' '[:lower:]')


In ci/scripts/r_docker_configure.sh line 52:
if [ ${R_CUSTOM_CCACHE} = "true" ]; then
     ^----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
if [ "${R_CUSTOM_CCACHE}" = "true" ]; then

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
  https://www.shellcheck.net/wiki/SC2223 -- This default assignment may cause...

What changes are included in this PR?

• SC2006 Use $(...) notation instead of legacy backticks
• SC2046: Quote variable to prevent word splitting.
• SC2086: Quote variable expansions.
• SC2223: Quote default variable assignments.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

• GitHub Issue: [CI][Dev] Fix shellcheck errors in the ci/scripts/r_docker_configure.sh #50766

[github-actions]

⚠️ GitHub issue #50766 has been automatically assigned in GitHub to PR creator.

[hiroyuki-sato]

@github-actions crossbow submit -g r

[github-actions]

Revision: 3f94d94

Submitted crossbow builds: ursacomputing/crossbow @ actions-06a65b33b5

Task	Status
r-binary-packages
r-recheck-most
test-r-alpine-linux-cran
test-r-arrow-backwards-compatibility
test-r-depsource-system
test-r-dev-duckdb
test-r-devdocs
test-r-extra-packages
test-r-fedora-clang
test-r-gcc-11
test-r-gcc-12
test-r-install-local
test-r-install-local-minsizerel
test-r-linux-as-cran
test-r-linux-rchk
test-r-linux-sanitizers
test-r-linux-valgrind
test-r-m1-san
test-r-macos-as-cran
test-r-offline-maximal
test-r-ubuntu-22.04
test-r-versions
test-r-wasm

[kou]

+1

[hiroyuki-sato]

@github-actions crossbow submit -g r

[github-actions]

Revision: 5556284

Submitted crossbow builds: ursacomputing/crossbow @ actions-962ba4dbba

Task	Status
r-binary-packages
r-recheck-most
test-r-alpine-linux-cran
test-r-arrow-backwards-compatibility
test-r-depsource-system
test-r-dev-duckdb
test-r-devdocs
test-r-extra-packages
test-r-fedora-clang
test-r-gcc-11
test-r-gcc-12
test-r-install-local
test-r-install-local-minsizerel
test-r-linux-as-cran
test-r-linux-rchk
test-r-linux-sanitizers
test-r-linux-valgrind
test-r-m1-san
test-r-macos-as-cran
test-r-offline-maximal
test-r-ubuntu-22.04
test-r-versions
test-r-wasm

[kou]

+1

[conbench-apache-arrow]

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit fd38cf6.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 38 possible false positives for unstable benchmarks that are known to sometimes produce them.

[conbench-apache-arrow]

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit fd38cf6.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 38 possible false positives for unstable benchmarks that are known to sometimes produce them.