GH-50495: [R] 25.0.0 Release followups - #50786
Conversation
|
|
|
|
github-actions
Bot
added
Component: R
awaiting committer review
There was a problem hiding this comment.
Pull request overview
Ports a set of post-25.0.0 R-package release-branch followups to main, primarily removing long-deprecated public APIs and aligning/generated documentation fixes.
Changes:
- Remove deprecated
arrow_available()andtype()from the public R API (code, exports, tests, and man pages). - Fix roxygen/operator cross-references so operator links resolve to
base::targets (viadata-raw/docgen.Rand regenerated docs). - Address a roxygen
@examplesIfissue indataset-format.Rby removing the problematic tag.
Reviewed changes
Copilot reviewed 8 out of 12 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| r/tests/testthat/test-type.R | Removes the deprecation test for type() now that the alias is deleted. |
| r/tests/testthat/test-arrow-info.R | Removes the deprecation test for arrow_available() now that the function is deleted. |
| r/R/type.R | Deletes the deprecated type() alias (wrapper around infer_type()). |
| r/R/dplyr-funcs-doc.R | Updates operator link targets to base::...() for roxygen markdown linking. |
| r/R/dataset-format.R | Removes an @examplesIf tag that was invalid/causing roxygen issues. |
| r/R/arrow-info.R | Deletes the deprecated arrow_available() helper. |
| r/NAMESPACE | Removes exports for arrow_available and type. |
| r/man/infer_type.Rd | Removes alias/usage entries for type() in the generated Rd. |
| r/man/FileSystem.Rd | Updates generated docs for filesystem notes (including removal of a Windows/Azure note). |
| r/man/arrow_info.Rd | Removes alias/usage entries for arrow_available() in the generated Rd. |
| r/man/acero.Rd | Regenerates operator links to base: topics and updates text. |
| r/data-raw/docgen.R | Updates doc generation to prefix operators with base:: in link targets. |
Files not reviewed (4)
- r/man/FileSystem.Rd: Generated file
- r/man/acero.Rd: Generated file
- r/man/arrow_info.Rd: Generated file
- r/man/infer_type.Rd: Generated file
| #' @export | ||
| infer_type <- function(x, ...) UseMethod("infer_type") | ||
|
|
|
|
| #' `AzureFileSystem` is not presently supported on Windows due to upstream | ||
| #' compatibility issues between the Azure C++ SDK and the MinGW toolchain. | ||
| #' |
There was a problem hiding this comment.
Added this here as it was wiped out when I ran make doc due to it being added to the .Rd on the original PR but not to this file where it needs to be.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 13 changed files in this pull request and generated no new comments.
Files not reviewed (4)
- r/man/FileSystem.Rd: Generated file
- r/man/acero.Rd: Generated file
- r/man/arrow_info.Rd: Generated file
- r/man/infer_type.Rd: Generated file
Suppressed comments (2)
r/man/acero.Rd:76
acero.Rdis generated fromR/dplyr-funcs-doc.R(see header), but the compute-function count here (254) is out of sync with the source doc file, which still says 281 (R/dplyr-funcs-doc.R:87). This will likely be reverted the next time docs are regenerated; please regenerate docs from the source (or updatedata-raw/docgen.Routput) so the count is consistent across the generated artifacts.
r/R/type.R:88- After removing the exported
type()alias, there are still user-facing messages in C++ type inference that referencetype()even though the code callsinfer_type()(e.g.,r/src/type_infer.cpp:225says "type() did not return..."). Updating that error text to mentioninfer_type()would avoid confusion now thattype()no longer exists.
#' @export
infer_type <- function(x, ...) UseMethod("infer_type")
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 13 changed files in this pull request and generated no new comments.
Files not reviewed (4)
- r/man/FileSystem.Rd: Generated file
- r/man/acero.Rd: Generated file
- r/man/arrow_info.Rd: Generated file
- r/man/infer_type.Rd: Generated file
github-actions
Bot
added
awaiting change review
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 14 changed files in this pull request and generated no new comments.
Files not reviewed (4)
- r/man/FileSystem.Rd: Generated file
- r/man/acero.Rd: Generated file
- r/man/arrow_info.Rd: Generated file
- r/man/infer_type.Rd: Generated file
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 66e3070. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 25 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
Changes from release branch need porting to main
What changes are included in this PR?
Port them to main
Are these changes tested?
No
Are there any user-facing changes?
Sure, we removed two defunct funcs