Skip to content

GH-50831: [Python] Avoid aborting on read-only output buffers #50833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
erichanwang wants to merge 2 commits into
base: main
Choose a base branch
from
+15 −0
Open

GH-50831: [Python] Avoid aborting on read-only output buffers #50833

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32eacf4
ARROW-50831 avoid abort on read-only output buffer
erichanwang Aug 9, 2026
6023209
GH-50831: [Python] Guard FixedSizeBufferWriter against read-only buffers
erichanwang Aug 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions python/pyarrow/io.pxi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1336,6 +1336,8 @@ cdef class FixedSizeBufferWriter(NativeFile):
"""

def __cinit__(self, Buffer buffer):
if not buffer.is_mutable:
raise ValueError("pa.FixedSizeBufferWriter() requires a mutable buffer")
self.output_stream.reset(new CFixedSizeBufferWriter(buffer.buffer))
self.is_writable = True

Expand Down
13 changes: 13 additions & 0 deletions python/pyarrow/tests/test_io.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2225,6 +2225,19 @@ def test_output_stream_errors(tmpdir):
with pytest.raises(ValueError):
pa.output_stream(buf, compression="foo")

for arg in [memoryview(b"x"), pa.py_buffer(b"x"),
memoryview(b""), pa.py_buffer(b"")]:
with pytest.raises(ValueError, match="requires a mutable buffer"):
pa.output_stream(arg)

for arg in [pa.py_buffer(b"x"), pa.py_buffer(b"")]:
with pytest.raises(ValueError, match="requires a mutable buffer"):
pa.FixedSizeBufferWriter(arg)

for arg in [memoryview(bytearray(1)), pa.py_buffer(bytearray(1))]:
with pa.output_stream(arg) as stream:
stream.write(b"x")

for arg in [bytearray(), StringIO()]:
with pytest.raises(TypeError):
pa.output_stream(arg)
Expand Down