Skip to content

GH-50860: [Dev][R][Swift][GLib] Simplify pre-commit file patterns for the r, swift, and c_glib directories - #50861

Merged
kou merged 4 commits into
apache:mainfrom
hiroyuki-sato:topic/shellcheck-simplify-r-swift-dirs
Aug 14, 2026
Merged

GH-50860: [Dev][R][Swift][GLib] Simplify pre-commit file patterns for the r, swift, and c_glib directories#50861
kou merged 4 commits into
apache:mainfrom
hiroyuki-sato:topic/shellcheck-simplify-r-swift-dirs

Conversation

@hiroyuki-sato

@hiroyuki-sato hiroyuki-sato commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator

Rationale for this change

This is the sub issue #44748.

  • Now that all r/*.sh and c_glib/*.sh files pass ShellCheck, simplify the pre-commit file pattern.
  • Remove ShellCheck checks for swift since it was moved to a separate repository.

What changes are included in this PR?

  • Remove ShellCheck checks for the swift/gen-protobuffers.sh file.
  • Use a wildcard for the r and c_glib directories check.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

@hiroyuki-sato hiroyuki-sato changed the title GH-50860: [Dev][R][Swift] Simplify pre-commit file patterns for the r and swift directories GH-50860: [Dev][R][Swift][GLib] Simplify pre-commit file patterns for the r and swift directories Aug 14, 2026
@hiroyuki-sato
hiroyuki-sato marked this pull request as ready for review August 14, 2026 03:04
@hiroyuki-sato
hiroyuki-sato requested a review from raulcd as a code owner August 14, 2026 03:04
@hiroyuki-sato

Copy link
Copy Markdown
Collaborator Author

wildcard workd fine

https://github.com/apache/arrow/actions/runs/31764146811/job/94656446242?pr=50861#step:5:114

Status: Downloaded newer image for koalaman/shellcheck:v0.11.0

In r/tools/download_dependencies_R.sh line 41:
  mkdir -p ${DESTDIR}
           ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
  mkdir -p "${DESTDIR}"


In r/inst/build_arrow_static.sh line 29:
: ${ARROW_HOME:=$(pwd)}                       # Only used in default SOURCE/BUILD dirs
  ^-------------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.

https://github.com/apache/arrow/actions/runs/31764752995/job/94658169328?pr=50861#step:5:176

In c_glib/test/run-test.sh line 33:
for module in ${modules[@]}; do
              ^-----------^ SC2068 (error): Double quote array expansions to avoid re-splitting elements.

@hiroyuki-sato hiroyuki-sato changed the title GH-50860: [Dev][R][Swift][GLib] Simplify pre-commit file patterns for the r and swift directories GH-50860: [Dev][R][Swift][GLib] Simplify pre-commit file patterns for the r, swift, and c_glib directories Aug 14, 2026

@kou kou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou
kou merged commit 4ace6dd into apache:main Aug 14, 2026
32 checks passed
@kou kou removed the awaiting review Awaiting review label Aug 14, 2026
@github-actions github-actions Bot added the awaiting merge Awaiting merge label Aug 14, 2026
@hiroyuki-sato
hiroyuki-sato deleted the topic/shellcheck-simplify-r-swift-dirs branch August 14, 2026 04:04
@conbench-apache-arrow

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 4ace6dd.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 23 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting merge Awaiting merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants