Skip to content

GH-51046: [Python][Interchange] Preserve the categorical ordered flag in from_dataframe #51045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Kayvan-Zahiri wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −4
Draft

GH-51046: [Python][Interchange] Preserve the categorical ordered flag in from_dataframe #51045

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion python/pyarrow/interchange/from_dataframe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,8 @@ def categorical_column_to_dictionary(
col.offset)

# Constructing a pa.DictionaryArray
dict_array = pa.DictionaryArray.from_arrays(indices, dictionary)
dict_array = pa.DictionaryArray.from_arrays(indices, dictionary,
ordered=categorical["is_ordered"])

return dict_array

Expand Down
8 changes: 5 additions & 3 deletions python/pyarrow/tests/interchange/test_conversion.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,7 @@ def test_pandas_roundtrip_categorical():
assert col_result.size() == col_table.size()
assert col_result.offset == col_table.offset

desc_cat_table = col_result.describe_categorical
desc_cat_table = col_table.describe_categorical
desc_cat_result = col_result.describe_categorical

assert desc_cat_table["is_ordered"] == desc_cat_result["is_ordered"]
Expand Down Expand Up @@ -380,10 +380,12 @@ def test_pyarrow_roundtrip(uint, int, float, np_float_str,


@pytest.mark.parametrize("offset, length", [(0, 10), (0, 2), (7, 3), (2, 1)])
def test_pyarrow_roundtrip_categorical(offset, length):
@pytest.mark.parametrize("ordered", [False, True])
def test_pyarrow_roundtrip_categorical(offset, length, ordered):
arr = ["Mon", "Tue", "Mon", "Wed", "Mon", "Thu", "Fri", None, "Sun"]
dict_type = pa.dictionary(pa.int32(), pa.string(), ordered=ordered)
table = pa.table(
{"weekday": pa.array(arr).dictionary_encode()}
{"weekday": pa.array(arr).dictionary_encode().cast(dict_type)}
)
table = table.slice(offset, length)
result = _from_dataframe(table.__dataframe__())
Expand Down
Loading