GH-51131: [C++][CI] Remove obsolete google-cloud-cpp macOS workaround - #51137
Draft
aryansk wants to merge 1 commit into
Draft
GH-51131: [C++][CI] Remove obsolete google-cloud-cpp macOS workaround#51137aryansk wants to merge 1 commit into
aryansk wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Issue #51131 tracks removal of the macOS compiler-warning workaround added for deprecated Abseil APIs in google-cloud-cpp. The upstream google-cloud-cpp fix referenced by the issue has now merged.
What changes are included in this PR?
Remove the APPLE-specific
-Wno-error=deprecated-declarationscompile option from the GCS filesystem sources. The existing documentation-warning options and unrelated Windows/reproducible-build workarounds are unchanged.Closes #51131
Are these changes tested?
git diff HEAD^ HEAD --checkAre there any user-facing changes?
No.
AI-assisted contribution
An AI coding assistant was used to help prepare this patch. The final change was kept to the single workaround requested by the issue and the exact diff was checked before publication; no third-party code or generated material was copied.