Skip to content

GH-51152: [R] test-r-linux-as-cran nightly fails with NOTE about non-standard top-level file jarl.toml - #51154

Merged
thisisnic merged 1 commit into
apache:mainfrom
thisisnic:GH-51152-jarl-followup
Sep 3, 2026
Merged

GH-51152: [R] test-r-linux-as-cran nightly fails with NOTE about non-standard top-level file jarl.toml#51154
thisisnic merged 1 commit into
apache:mainfrom
thisisnic:GH-51152-jarl-followup

Conversation

@thisisnic

@thisisnic thisisnic commented Sep 3, 2026

Copy link
Copy Markdown
Member

Rationale for this change

The test-r-linux-as-cran nightly job has been failing since 2026-08-25 because r/jarl.toml (added in #50851) ends up in the package tarball and R CMD check flags it as a non-standard top-level file.

What changes are included in this PR?

Adds jarl.toml to r/.Rbuildignore, and removes the now-unused r/.lintr config along with its .Rbuildignore and RAT exclude entries.

Are these changes tested?

Checked locally that the .Rbuildignore pattern matches jarl.toml without excluding anything else. The test-r-linux-as-cran crossbow job will confirm the NOTE is gone.

Are there any user-facing changes?

No.

Copilot AI lite review requested due to automatic review settings September 3, 2026 14:12
@thisisnic

Copy link
Copy Markdown
Member Author

@github-actions crossbow submit test-r-linux-as-cran

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown

⚠️ GitHub issue #51152 has been automatically assigned in GitHub to PR creator.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The PR description still contains the unedited template text (including breaking/critical fix boilerplate) and should be updated/cleaned up before merge.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR addresses an R CMD check NOTE in the CRAN-style CI job caused by r/jarl.toml being included in the built R package tarball as a non-standard top-level file.

Changes:

  • Add ^jarl\.toml$ to r/.Rbuildignore so jarl.toml is excluded from the R package build.
  • Remove the now-unused r/.lintr configuration file.
  • Remove the corresponding r/.lintr exclusion entry from the RAT release exclude list.
File summaries
File Description
r/.Rbuildignore Adds an ignore rule for jarl.toml to prevent CRAN NOTE.
r/.lintr Deletes the lintr configuration file (no longer referenced).
dev/release/rat_exclude_files.txt Removes obsolete exclusion for a deleted file.
Review details
  • Files reviewed: 3/3 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown

Revision: b55a691

Submitted crossbow builds: ursacomputing/crossbow @ actions-ee963f0f15

Task Status
test-r-linux-as-cran GitHub Actions

@thisisnic
thisisnic merged commit ce6fb9f into apache:main Sep 3, 2026
35 checks passed
@thisisnic thisisnic removed the awaiting committer review Awaiting committer review label Sep 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants