ARROW-6058: [C++][Parquet] Validate whole ColumnChunk raw data reads so that underlying filesystem issues are caught earlier - #5137
Closed
wesm wants to merge 3 commits into
Closed
ARROW-6058: [C++][Parquet] Validate whole ColumnChunk raw data reads so that underlying filesystem issues are caught earlier#5137wesm wants to merge 3 commits into
wesm wants to merge 3 commits into
Conversation
Member
Author
|
I'm going to add a unit test, pls hold off on merging |
…aw data from segment of Parquet file
Member
Author
|
done |
Codecov Report
@@ Coverage Diff @@
## master #5137 +/- ##
=========================================
Coverage ? 75.26%
=========================================
Files ? 57
Lines ? 3619
Branches ? 0
=========================================
Hits ? 2724
Misses ? 895
Partials ? 0Continue to review full report at Codecov.
|
Member
Author
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incomplete reads from files were not being caught here, which would result in an unhelpful exception being raised later when data pages could not be decoded. If the entire ColumnChunk read is incomplete here, then the chunk cannot be deserialized, so raising an error here is the proper thing to do. This also helped me debug the root cause of ARROW-6058