ARROW-6372: [Rust][Datafusion] Casting from Un-signed to Signed Integers not supported#5224
Closed
paddyhoran wants to merge 1 commit intoapache:masterfrom
Closed
ARROW-6372: [Rust][Datafusion] Casting from Un-signed to Signed Integers not supported#5224paddyhoran wants to merge 1 commit intoapache:masterfrom
paddyhoran wants to merge 1 commit intoapache:masterfrom
Conversation
nevi-me
reviewed
Aug 29, 2019
| }, | ||
| Int16 => match type_from { | ||
| Int8 | Int16 => true, | ||
| Int8 | Int16 | UInt8 => true, |
Contributor
There was a problem hiding this comment.
silly question, but are we excluding UInt16 here because it could overflow?
Contributor
Author
There was a problem hiding this comment.
That's my understanding, yes.
Codecov Report
@@ Coverage Diff @@
## master #5224 +/- ##
===========================================
- Coverage 87.67% 82.73% -4.95%
===========================================
Files 1025 91 -934
Lines 147030 25599 -121431
Branches 1437 0 -1437
===========================================
- Hits 128915 21180 -107735
+ Misses 17753 4419 -13334
+ Partials 362 0 -362
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.