Skip to content

ARROW-6771: [Packaging][Python] Missing pytest dependency from conda and wheel builds #5569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kszucs wants to merge 5 commits into from
Closed

ARROW-6771: [Packaging][Python] Missing pytest dependency from conda and wheel builds #5569

kszucs wants to merge 5 commits into from

Conversation

@kszucs
Copy link
Member

@kszucs kszucs commented Oct 2, 2019

No description provided.

@kszucs
Copy link
Member Author

kszucs commented Oct 2, 2019

@ursabot crossbow submit -g conda

@ursabot
Copy link

ursabot commented Oct 2, 2019

AMD64 Conda Crossbow Submit (#67030) builder has been succeeded.

Revision: 350aa4f

Submitted crossbow builds: ursa-labs/crossbow @ ursabot-234

Task Status
conda-linux-gcc-py27 Azure
conda-linux-gcc-py36 Azure
conda-linux-gcc-py37 Azure
conda-osx-clang-py27 Azure
conda-osx-clang-py36 Azure
conda-osx-clang-py37 Azure
conda-win-vs2015-py36 Azure
conda-win-vs2015-py37 Azure

@github-actions
Copy link

github-actions bot commented Oct 2, 2019

https://issues.apache.org/jira/browse/ARROW-6771

@kszucs
Copy link
Member Author

kszucs commented Oct 2, 2019

@ursabot crossbow submit -g conda -g wheel

@ursabot
Copy link

ursabot commented Oct 2, 2019

AMD64 Conda Crossbow Submit (#67048) builder has been succeeded.

Revision: ebd42de

Submitted crossbow builds: ursa-labs/crossbow @ ursabot-235

Task Status
conda-linux-gcc-py27 Azure
conda-linux-gcc-py36 Azure
conda-linux-gcc-py37 Azure
conda-osx-clang-py27 Azure
conda-osx-clang-py36 Azure
conda-osx-clang-py37 Azure
conda-win-vs2015-py36 Azure
conda-win-vs2015-py37 Azure
wheel-manylinux1-cp27m TravisCI
wheel-manylinux1-cp27mu TravisCI
wheel-manylinux1-cp35m TravisCI
wheel-manylinux1-cp36m TravisCI
wheel-manylinux1-cp37m TravisCI
wheel-manylinux2010-cp27m TravisCI
wheel-manylinux2010-cp27mu TravisCI
wheel-manylinux2010-cp35m TravisCI
wheel-manylinux2010-cp36m TravisCI
wheel-manylinux2010-cp37m TravisCI
wheel-osx-cp27m TravisCI
wheel-osx-cp35m TravisCI
wheel-osx-cp36m TravisCI
wheel-osx-cp37m TravisCI
wheel-win-cp35m Appveyor
wheel-win-cp36m Appveyor
wheel-win-cp37m Appveyor

@kszucs
Copy link
Member Author

kszucs commented Oct 2, 2019

@ursabot crossbow submit wheel-win-cp35m wheel-win-cp36m wheel-win-cp37m

@ursabot
Copy link

ursabot commented Oct 2, 2019

AMD64 Conda Crossbow Submit (#67119) builder has been succeeded.

Revision: 1baeb43

Submitted crossbow builds: ursa-labs/crossbow @ ursabot-236

Task Status
wheel-win-cp35m Appveyor
wheel-win-cp36m Appveyor
wheel-win-cp37m Appveyor

@codecov-io
Copy link

codecov-io commented Oct 3, 2019 •
edited
Loading

Codecov Report

Merging #5569 into master will decrease coverage by 22.14%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #5569       +/-   ##
===========================================
- Coverage   88.58%   66.43%   -22.15%     
===========================================
  Files         967      516      -451     
  Lines      128766    71207    -57559     
  Branches     1501        0     -1501     
===========================================
- Hits       114066    47308    -66758     
- Misses      14335    23899     +9564     
+ Partials      365        0      -365
Impacted Files Coverage Δ
python/pyarrow/tests/conftest.py 68.3% <0%> (ø) ⬆️
cpp/src/arrow/util/memory.h 0% <0%> (-100%) ⬇️
cpp/src/arrow/filesystem/path_tree.h 0% <0%> (-100%) ⬇️
cpp/src/gandiva/date_utils.h 0% <0%> (-100%) ⬇️
cpp/src/arrow/util/memory.cc 0% <0%> (-100%) ⬇️
cpp/src/gandiva/decimal_type_util.h 0% <0%> (-100%) ⬇️
cpp/src/arrow/compute/logical_type.h 0% <0%> (-100%) ⬇️
cpp/src/parquet/hasher.h 0% <0%> (-100%) ⬇️
cpp/src/gandiva/basic_decimal_scalar.h 0% <0%> (-100%) ⬇️
cpp/src/arrow/compute/kernels/boolean.cc 0% <0%> (-100%) ⬇️
... and 705 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f93f85...43cceea. Read the comment docs.

@kszucs
Copy link
Member Author

kszucs commented Oct 3, 2019

@ursabot crossbow submit wheel-win-cp35m wheel-win-cp36m wheel-win-cp37m

@ursabot
Copy link

ursabot commented Oct 3, 2019

AMD64 Conda Crossbow Submit (#67244) builder has been succeeded.

Revision: f61a1ea

Submitted crossbow builds: ursa-labs/crossbow @ ursabot-237

Task Status
wheel-win-cp35m Appveyor
wheel-win-cp36m Appveyor
wheel-win-cp37m Appveyor

pitrou
pitrou approved these changes Oct 3, 2019
View reviewed changes
Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@pitrou
Copy link
Member

pitrou commented Oct 3, 2019

Looks like Python 3.5 failed building? Personally, I'd be fine with dropping Python 3.5 packages, but should be checked on the ML.

@wesm
Copy link
Member

wesm commented Oct 3, 2019

Looks like there is a pip dependency conflict. I would also recommend dropping Python 3.5 Windows packages; these are unlikely to be used by very many people nowadays

@kszucs
Copy link
Member Author

kszucs commented Oct 3, 2019

Ok, dropping it.

wesm
wesm approved these changes Oct 3, 2019
View reviewed changes
Copy link
Member

@wesm wesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wesm wesm closed this in b5ccbd2 Oct 3, 2019
kszucs added a commit that referenced this pull request Oct 5, 2019
@kszucs
ARROW-6771: [Packaging][Python] Missing pytest dependency from conda …
740231d 
…and wheel builds

Closes #5569 from kszucs/ARROW-6771 and squashes the following commits:

43cceea <Krisztián Szűcs> drop wheel-win-cp35m
f61a1ea <Krisztián Szűcs> use conda-forge
1baeb43 <Krisztián Szűcs> use conda_env_python in windows wheels
ebd42de <Krisztián Szűcs> properly skip is minio binary is missing
350aa4f <Krisztián Szűcs> conda test dependency

Authored-by: Krisztián Szűcs <szucs.krisztian@gmail.com>
Signed-off-by: Wes McKinney <wesm+git@apache.org>
@keller00
Copy link

keller00 commented Mar 5, 2020

Hi,

I'd like to help getting pyarrow==0.16.0 released for Windows Python 3.5.
I have seen the issue here: https://ci.appveyor.com/project/Ursa-Labs/crossbow/builds/27848124
I'm not familiar with your release build procedure, but I have been trying to follow https://github.com/apache/arrow/blob/master/docs/source/developers/python.rst#building-on-windows
Note that I have replaced:

conda create -y -n pyarrow-dev -c conda-forge ^
    --file arrow\ci\conda_env_cpp.yml ^
    --file arrow\ci\conda_env_python.yml ^
    --file arrow\ci\conda_env_gandiva.yml ^
    python=3.7

with

conda create -y -n pyarrow-dev -c conda-forge ^
    --file arrow\ci\conda_env_cpp.yml ^
    --file arrow\ci\conda_env_python.yml ^
    --file arrow\ci\conda_env_gandiva.yml ^
    python=3.5

I also had to update Cython manually and that python setup.py build_ext --inplace seemed to do nothing, so I tried doing pip wheel -w dist . and this successfully built a wheel file for me.

I understand that ursabot is down, but when it comes back could you retry building the missing wheel?

If I am wrong about the build procedure please let me know, I'm really unfamiliar with Windows development.

@wesm
Copy link
Member

wesm commented Mar 5, 2020

@keller00 can we discuss on the mailing list or a new JIRA issue about this? Thanks

@asfimport asfimport mentioned this pull request Mar 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wesm wesm wesm approved these changes

@pitrou pitrou pitrou approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@kszucs @ursabot @codecov-io @pitrou @wesm @keller00