Skip to content

ARROW-7199: [Java] Fix ConcurrentModificationException in BaseAllocator::getChildAllocators#5856

Closed
pprudhvi wants to merge 1 commit intoapache:masterfrom
pprudhvi:sync-basealloc
Closed

ARROW-7199: [Java] Fix ConcurrentModificationException in BaseAllocator::getChildAllocators#5856
pprudhvi wants to merge 1 commit intoapache:masterfrom
pprudhvi:sync-basealloc

Conversation

@pprudhvi
Copy link
Copy Markdown
Contributor

@pprudhvi pprudhvi commented Nov 18, 2019

synchronize on childAllocators map when iterating on its entries using keySet/entrySet views

@pprudhvi pprudhvi changed the title [WIP]: [Java] synchronise on childAllocators while iterating on keySet view ARROW-7199: [Java] fix ConcurrentModificationException in BaseAllocator::getChildAllocators Nov 18, 2019
@github-actions
Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

@pravindra pravindra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@pprudhvi can you please add the stack trace for the exception in the jira ?

@pprudhvi
Copy link
Copy Markdown
Contributor Author

done. Thanks for reviewing

@kszucs kszucs changed the title ARROW-7199: [Java] fix ConcurrentModificationException in BaseAllocator::getChildAllocators ARROW-7199: [Java] Fix ConcurrentModificationException in BaseAllocator::getChildAllocators Nov 18, 2019
@kszucs kszucs closed this in ec50473 Nov 18, 2019
@kszucs
Copy link
Copy Markdown
Member

kszucs commented Nov 18, 2019

Thanks @pprudhvi!

pprudhvi added a commit to dremio/arrow that referenced this pull request Nov 19, 2019
…or::getChildAllocators

synchronize on childAllocators map when iterating on its entries using keySet/entrySet views

Closes apache#5856 from pprudhvi/sync-basealloc and squashes the following commits:

052dd83 <Prudhvi Porandla> synchronise over childallocators while iterating on keyset view

Authored-by: Prudhvi Porandla <prudhvi.porandla@icloud.com>
Signed-off-by: Krisztián Szűcs <szucs.krisztian@gmail.com>
@pprudhvi pprudhvi deleted the sync-basealloc branch April 22, 2020 03:05
pribor pushed a commit to GlobalWebIndex/arrow that referenced this pull request Oct 24, 2025
…or::getChildAllocators

synchronize on childAllocators map when iterating on its entries using keySet/entrySet views

Closes apache#5856 from pprudhvi/sync-basealloc and squashes the following commits:

052dd83 <Prudhvi Porandla> synchronise over childallocators while iterating on keyset view

Authored-by: Prudhvi Porandla <prudhvi.porandla@icloud.com>
Signed-off-by: Krisztián Szűcs <szucs.krisztian@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants