Skip to content

ARROW-7199: [Java] Fix ConcurrentModificationException in BaseAllocator::getChildAllocators #5856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pprudhvi wants to merge 1 commit into from
Closed

ARROW-7199: [Java] Fix ConcurrentModificationException in BaseAllocator::getChildAllocators #5856

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions java/memory/src/main/java/org/apache/arrow/memory/BaseAllocator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,9 @@ public BufferAllocator getParentAllocator() {

@Override
public Collection<BufferAllocator> getChildAllocators() {
return new HashSet<>(childAllocators.keySet());
synchronized (childAllocators) {
return new HashSet<>(childAllocators.keySet());
}
}

private static String createErrorMsg(final BufferAllocator allocator, final int rounded, final int requested) {
Expand Down Expand Up @@ -449,8 +451,10 @@ public synchronized void close() {
} else {
if (!childAllocators.isEmpty()) {
outstandingChildAllocators.append("Outstanding child allocators : \n");
for (final BaseAllocator childAllocator : childAllocators.keySet()) {
outstandingChildAllocators.append(String.format(" %s", childAllocator.toString()));
synchronized (childAllocators) {
for (final BaseAllocator childAllocator : childAllocators.keySet()) {
outstandingChildAllocators.append(String.format(" %s", childAllocator.toString()));
}
}
}
}
Expand Down