ARROW-6891: [Rust] [Parquet] utf8 support for arrow reader.#5923
Closed
liurenjie1024 wants to merge 3 commits intoapache:masterfrom
Closed
ARROW-6891: [Rust] [Parquet] utf8 support for arrow reader.#5923liurenjie1024 wants to merge 3 commits intoapache:masterfrom
liurenjie1024 wants to merge 3 commits intoapache:masterfrom
Conversation
Contributor
Author
|
@sunchao @andygrove @nevi-me @paddyhoran Please take a look when your are available. |
nevi-me
reviewed
Dec 1, 2019
| PhysicalType::BYTE_ARRAY | ||
| if cur_type.get_basic_info().logical_type() == LogicalType::UTF8 => | ||
| { | ||
| Ok(Box::new(ComplexObjectArrayReader::< |
Contributor
There was a problem hiding this comment.
Out of curiousity, would the ComplexObjectArrayReader allow us to implement arrow::BinaryArray and arrow::FixedSizeBinaryArray in future?
Contributor
Author
There was a problem hiding this comment.
Yes, we just need converter for those types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UTF8 support for arrow reader.