Skip to content

ARROW-8616: [Rust] Turn explicit SIMD off by default#7057

Closed
paddyhoran wants to merge 4 commits intoapache:masterfrom
paddyhoran:turn-off-simd
Closed

ARROW-8616: [Rust] Turn explicit SIMD off by default#7057
paddyhoran wants to merge 4 commits intoapache:masterfrom
paddyhoran:turn-off-simd

Conversation

@paddyhoran
Copy link
Copy Markdown
Contributor

We will be removing explicit SIMD in #7037, this PR removes it from the default features in preparation of removing it completely.

@github-actions
Copy link
Copy Markdown

Copy link
Copy Markdown
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM subject to fixing CI failure

@nevi-me
Copy link
Copy Markdown
Contributor

nevi-me commented May 2, 2020

LGTM subject to fixing CI failure

We have to rewrite the divide kernel for tets to pass. I've done this as part of #7037 by creating a slower path if the LHS array has nulls.

Copy link
Copy Markdown
Contributor

@nevi-me nevi-me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hadn't seen that you fixed the divide error, thanks @paddyhoran

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants