ARROW-10740: [Rust][DataFusion] Remove redundant clones found by clippy #8771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nevi-me
approved these changes
Nov 26, 2020
Contributor
nevi-me
left a comment
nevi-me
left a comment
There was a problem hiding this comment.
Thanks @Dandandan, the plan was to disable all lints at once, then enable them piecemeal, so thanks for working on this.
We should look at https://issues.apache.org/jira/browse/ARROW-9978 before opening separate JIRAs, to reduce duplication.
Contributor
Author
|
Thanks @nevi-me . I found the comment / previous issue, thanks for the link to the Jira story. Makes sense to coordinate / plan this a bit 👍 |
andygrove
approved these changes
Nov 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this clippy warning is useful to have in CI and reduces noise in the code (and maybe some small performance or compile time wins).