AVRO-3120: Upgrade maven-maven-plugin and spotless to a more recent version#1246
Merged
RyanSkraba merged 1 commit intoapache:masterfrom Jun 3, 2021
Merged
AVRO-3120: Upgrade maven-maven-plugin and spotless to a more recent version#1246RyanSkraba merged 1 commit intoapache:masterfrom
RyanSkraba merged 1 commit intoapache:masterfrom
Conversation
RyanSkraba
approved these changes
Jun 3, 2021
| <pluginExecutionFilter> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-plugin-plugin</artifactId> | ||
| <versionRange>[${plugin-plugin.version},)</versionRange> |
Contributor
There was a problem hiding this comment.
Huh .. is this even defined someplace? Glad to get rid of it, I guess!
Member
Author
There was a problem hiding this comment.
No, it wasn't! that's why it was looking an older version and breaking the build on Java 17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The maven-maven-plugin upgrade is just to fix a maven issue when building with Java 17, sadly there seems not to be a 3.8.x version to keep them aligned yet.
R: @RyanSkraba