Skip to content

AVRO-3120: Upgrade maven-maven-plugin and spotless to a more recent version #1246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RyanSkraba merged 1 commit into from
Jun 3, 2021
Merged

AVRO-3120: Upgrade maven-maven-plugin and spotless to a more recent version #1246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion lang/java/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,6 @@
<pluginExecutionFilter>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-plugin-plugin</artifactId>
<versionRange>[${plugin-plugin.version},)</versionRange>
Copy link
Contributor

@RyanSkraba RyanSkraba Jun 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh .. is this even defined someplace? Glad to get rid of it, I guess!

Copy link
Member Author

@iemejia iemejia Jun 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it wasn't! that's why it was looking an older version and breaking the build on Java 17

<goals>
<goal>helpmojo</goal>
<goal>descriptor</goal>
Expand Down
9 changes: 8 additions & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,10 @@
<checkstyle-plugin.version>3.1.2</checkstyle-plugin.version>
<checkstyle.version>8.42</checkstyle.version>
<enforcer-plugin.version>3.0.0-M3</enforcer-plugin.version>
<maven-plugin-plugin.version>3.6.1</maven-plugin-plugin.version>
<plugin-tools-javadoc.version>3.5</plugin-tools-javadoc.version>
<extra-enforcer-rules.version>1.3</extra-enforcer-rules.version>
<spotless-maven-plugin.version>2.10.3</spotless-maven-plugin.version>
<spotless-maven-plugin.version>2.11.1</spotless-maven-plugin.version>
<surefire.version>3.0.0-M5</surefire.version>
</properties>

Expand Down Expand Up @@ -105,6 +106,11 @@
<artifactId>spotless-maven-plugin</artifactId>
<version>${spotless-maven-plugin.version}</version>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-plugin-plugin</artifactId>
<version>${maven-plugin-plugin.version}</version>
</plugin>
</plugins>
</pluginManagement>
<plugins>
Expand Down Expand Up @@ -194,6 +200,7 @@
</dependencies>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-plugin-plugin</artifactId>
<configuration>
<goalPrefix>avro</goalPrefix>
Expand Down