AVRO-3411: Support VSCode devcontainer#1557
AVRO-3411: Support VSCode devcontainer#1557iemejia merged 4 commits intoapache:masterfrom zcsizmadia:avro-3411-support-devcontainer
Conversation
iemejia
left a comment
There was a problem hiding this comment.
Thanks for bringing this one in @zcsizmadia !
I let some minor comments.
| @@ -0,0 +1,62 @@ | |||
| # Set default behavior to automatically normalize line endings. | |||
There was a problem hiding this comment.
Do we really need this? Specially all the 'auto', isn't auto the default?
Should we cover the formats we don't care about e.g. doc/pdf/rtf?
I don't remember where we are towards line endings. @RyanSkraba maybe?
There was a problem hiding this comment.
There was a discussion on this about AVRO-3150 -- some tests were failing due to an overzealous checkstyle check IIRC.
Is there something that fails if this .gitattributes isn't present? I'm not familiar with all the attributes, I admit! What does diff and astextplain do?
I have no objection to enforcing that script files are CRLF/LF no matter where they're checked out!
RyanSkraba
left a comment
There was a problem hiding this comment.
I would love to take a closer look at this -- to be honest, I've always kind of disliked the uberjar, but this is a pretty neat feature!
|
I heavily use devcontainer for other multi language/multi platform projects. AFAIK VSCode is the most used editor for such projects. I like the fact that e.g. when I developed the extra codecs for C# , I could just generate the interop data for all the other languages, so my C# tests were running againsta ll the compression codecs generated by the other languages. |
|
It is possible to have devcontainer config for each languages seperately, however since the dockerfile has all the tools and all the project depend on each other via the interop tests, I thought having full container setup for the whole project (based on the already existing dockerfile) makes more sense |
iemejia
left a comment
There was a problem hiding this comment.
LGTM
I validated it in a local container on mac and it works.
I had some issues with the C# project import but we can fix those afterwards, merging this is great for the benefit of everyone who can now contribute in an easy reproducile way. Excellent work @zcsizmadia !
* Add devcontainer file * Add info to BUILD.md * Fix whitespaces * Add only scripts to gitattributes Co-authored-by: Zoltan Csizmadia <CsizmadiaZ@valassis.com>
Make sure you have checked all steps below.
Jira
Tests
Commits
Documentation