-
Notifications
You must be signed in to change notification settings - Fork 1.7k
AVRO-3411: Support VSCode devcontainer #1557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
iemejia
merged 4 commits into
apache:master
from
zcsizmadia:avro-3411-support-devcontainer
Feb 25, 2022
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| { | ||
| "name": "Avro Development", | ||
|
|
||
| "build": { "dockerfile": "../share/docker/Dockerfile" }, | ||
|
|
||
| // Use 'settings' to set *default* container specific settings.json values on container create. | ||
| // You can edit these settings after create using File > Preferences > Settings > Remote. | ||
| "settings": { | ||
| }, | ||
|
|
||
| // Add the IDs of extensions you want installed when the container is created in the array below. | ||
| "extensions": [ | ||
| // Python | ||
| "ms-python.python", | ||
| "ms-python.vscode-pylance", | ||
|
|
||
| // C/C++ | ||
| "ms-vscode.cpptools", | ||
|
|
||
| // C# | ||
| "ms-dotnettools.csharp", | ||
|
|
||
| // Rust | ||
| "vadimcn.vscode-lldb", | ||
| "mutantdino.resourcemonitor", | ||
| "matklad.rust-analyzer", | ||
| "tamasfe.even-better-toml", | ||
| "serayuzgur.crates", | ||
|
|
||
| // Java | ||
| "vscjava.vscode-java-pack", | ||
|
|
||
| // Shell script | ||
| "timonwong.shellcheck", | ||
|
|
||
| // YAML | ||
| "redhat.vscode-yaml", | ||
|
|
||
| // Git | ||
| "eamodio.gitlens" | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| # Set default behavior to automatically normalize line endings. | ||
| * text=auto | ||
|
|
||
| # Force bash scripts to always use lf line endings so that if a repo is accessed | ||
| # in Unix via a file share from Windows, the scripts will work. | ||
| *.sh text eol=lf | ||
|
|
||
| # Force batch scripts to always use crlf line endings so that if a repo is accessed | ||
| # in Unix via a file share from Windows, the scripts will work. | ||
| *.cmd text eol=crlf | ||
| *.bat text eol=crlf | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need this? Specially all the 'auto', isn't auto the default?
Should we cover the formats we don't care about e.g. doc/pdf/rtf?
I don't remember where we are towards line endings. @RyanSkraba maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a discussion on this about AVRO-3150 -- some tests were failing due to an overzealous checkstyle check IIRC.
Is there something that fails if this
.gitattributesisn't present? I'm not familiar with all the attributes, I admit! What doesdiffandastextplaindo?I have no objection to enforcing that script files are CRLF/LF no matter where they're checked out!