AVRO-1982: Fix static code analyzer findings.#173
Closed
zivanfi wants to merge 1 commit intoapache:masterfrom
zivanfi:sonar-issues
Closed
AVRO-1982: Fix static code analyzer findings.#173zivanfi wants to merge 1 commit intoapache:masterfrom zivanfi:sonar-issues
zivanfi wants to merge 1 commit intoapache:masterfrom
zivanfi:sonar-issues
Conversation
Member
|
+1. Can you open a JIRA to go with this please? |
zivanfi
changed the title
Author
|
@tomwhite I created a JIRA and referenced it in the commit message. |
Member
|
I get the following compilation error: |
Author
|
I don't know how that happened - I probably ran mvn test in a different dir, sorry about that. Will fix as soon as I have time. |
Fixed several possible null pointer exceptions and unchecked casts. These triggered security and code health warnings in our static code analyzer tools.
Author
|
Fixed, PTAL. |
iemejia
referenced
this pull request
in iemejia/avro
May 24, 2021
…es (#173) * Added ability to parse a list of schemas, which may have cross dependencies. Added tests * Fixing the formatting * A bit more formatting * Added a comma to please clippy * Switched an ok_or to an ok_or_else at the behest of clippy * Following fixes: Fixed some docstrings, a new error for name collisions when using parse_list, guarantees that input order matches output order * Removed an unused import * Small formatting fixes * Added another test involving fullnames * Added test that ensures when a recursive type is put in, the algorithm does blow the top off the stack but returns an error * removed unused variable * Updated readme and one tiny fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed several possible null pointer exceptions and unchecked casts.
These triggered security and code health warnings in our static code
analyzer tools.