Closed
Conversation
Signed-off-by: sacharya <suraj.spa@gmail.com>
busbey
reviewed
Feb 15, 2017
Contributor
busbey
left a comment
busbey
left a comment
There was a problem hiding this comment.
Why not include the example script in the patch as well? then we could just invoke it directly on the asf jenkins hosts.
| fi | ||
| docker build -t avro-build-${USER_NAME} - <<UserSpecificDocker | ||
| FROM avro-build | ||
| FROM docker.io/surajacharya/avro-build-test |
Contributor
There was a problem hiding this comment.
presumably this will be an image from the project before we start using this?
Contributor
Author
There was a problem hiding this comment.
Yes. Once there is a general consensus that the base image being used is good enough I intend to move it to a more central location (apache docker hub) and point it to that.
| # See BUILD.txt. | ||
|
|
||
| FROM java:7-jdk | ||
| FROM docker.io/surajacharya/avro-build-test |
Contributor
There was a problem hiding this comment.
presumably this will be an image from the project before we start using this?
Contributor
Author
|
Okay i will add the script to the patch shortly. |
Contributor
|
any update on including the example script? |
Contributor
|
Superseded by #353 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have made the setup to use yetus.
A quick setup of yetus can be done using this script : https://gist.github.com/spacharya/c1013fda8fe5d864fd028e8e5c478b81
You will need to have docker present on that machine.
/bin/bash ../yetus/precommit/test-patch.sh --plugins=all,-compile,-javadoc --user-plugins=share/pre_commit/ --build-tool=build https://github.com/apache/avro/pull/191 --docker --dockerFile=share/docker/Dockerfile --dirty-workspaceIs a sample deployment.
I would appreciate if people can look at the changes and test it and let me know if there are any improvements.