AVRO-1887 Integrate Yetus and fix tests#353
Conversation
lang/java/ipc/src/test/java/org/apache/avro/DataFileInteropTest.java
Outdated
Show resolved
Hide resolved
lang/java/tools/src/test/compiler/output-string/avro/examples/baseball/Player.java
Show resolved
Hide resolved
c28c31e to
a5a21e2
Compare
kojiromike
left a comment
There was a problem hiding this comment.
I don't know Yetus at all, but I'm assuming it'll give us some useful feedback in github checks. I have some suggestions for bash script improvements. Can Yetus be configured to run shellcheck on them?
c2916d8 to
5cc2e4f
Compare
|
Thanks for the review @kojiromike Enabling There is also support for hadolint etc. |
44e5865 to
4fdcb14
Compare
10e1c2a to
778e9e2
Compare
77faaf5 to
057636a
Compare
|
@kojiromike @cutting PTAL. I know there are a crazy amount of changes. Instead of having fixed paths, I updated all the tests to use TemporaryDirectories using junit. Also, I've rewritten a lot of the file operations using |
|
@kojiromike My suggestion would be to merge this first, and then you can freely rework the shell scripts. You're much better at it than me :-) |
Signed-off-by: sacharya <suraj.spa@gmail.com>
2d234b0 to
4807128
Compare
Add a precommit hook using Apache Yetus that will invoke the test suite of the different languages - Disable Ruby integration tests tests - Fix Flaky Java Datetime test When the milsecons would have trailing zero, it would get trimmed - Align the order of imports
|
@Fokko Congratulations/Thanks for getting this merged. I'll take a look at those shell scripts. Am I correct that now we can rely on automated checks to validate a lot of our PRs? Is there a way to trigger the tests on all the open PRs? |
|
@kojiromike with pleasure. They need to rebase onto master, then Travis will run automatically. I'm going through a couple of the PR's that are still open. |
|
FWIW, very specific support for Travis (and other CI systems) is something that will hopefully be coming to Yetus soon. I've got it in a fork already: effectivemachines/buretoolbox@f055aa3 |
All,
First PR that will kick off the tests using Apache Yetus. It is a crude implementation since it will only kick off the
./build.sh, but this will be refined later on.The C++ and the interop tests are failing and are therefore disabled for now.
cc @kojiromike
Cheers, Fokko