Skip to content

AVRO-2822: Add warning to an experimental method. - #897

Merged
iemejia merged 2 commits into
apache:masterfrom
RyanSkraba:AVRO-2822-warning
Jun 1, 2020
Merged

AVRO-2822: Add warning to an experimental method.#897
iemejia merged 2 commits into
apache:masterfrom
RyanSkraba:AVRO-2822-warning

Conversation

@RyanSkraba

Copy link
Copy Markdown
Contributor

Adds a warning to the new toString(...) method. This is currently the only way to accomplish what the user is looking to do, but we'd like to provide a better solution in the short term (but after the 1.10.0 release).

Jira

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

@probot-autolabeler probot-autolabeler Bot added the Java Pull Requests for Java binding label May 29, 2020

@iemejia iemejia left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iemejia
iemejia merged commit 42d81d7 into apache:master Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Java Pull Requests for Java binding

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants