Skip to content

Update google-apitools requirement from <0.5.32,>=0.5.31 to >=0.5.31,<0.5.33 in /sdks/python#22016

Closed
dependabot[bot] wants to merge 1 commit intomasterfrom
dependabot/pip/sdks/python/google-apitools-gte-0.5.31-and-lt-0.5.33
Closed

Update google-apitools requirement from <0.5.32,>=0.5.31 to >=0.5.31,<0.5.33 in /sdks/python#22016
dependabot[bot] wants to merge 1 commit intomasterfrom
dependabot/pip/sdks/python/google-apitools-gte-0.5.31-and-lt-0.5.33

Conversation

@dependabot
Copy link
Copy Markdown
Contributor

@dependabot dependabot bot commented on behalf of github Jun 23, 2022

Updates the requirements on google-apitools to permit the latest version.

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Updates the requirements on [google-apitools](https://github.com/google/apitools) to permit the latest version.
- [Release notes](https://github.com/google/apitools/releases)
- [Commits](google/apitools@v0.5.31...v0.5.32)

---
updated-dependencies:
- dependency-name: google-apitools
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file python labels Jun 23, 2022
@asf-ci
Copy link
Copy Markdown

asf-ci commented Jun 23, 2022

Can one of the admins verify this patch?

2 similar comments
@asf-ci
Copy link
Copy Markdown

asf-ci commented Jun 23, 2022

Can one of the admins verify this patch?

@asf-ci
Copy link
Copy Markdown

asf-ci commented Jun 23, 2022

Can one of the admins verify this patch?

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 23, 2022

Codecov Report

Merging #22016 (f1f478d) into master (78ec29e) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #22016   +/-   ##
=======================================
  Coverage   73.99%   73.99%           
=======================================
  Files         703      703           
  Lines       92936    92936           
=======================================
+ Hits        68764    68766    +2     
+ Misses      22906    22904    -2     
  Partials     1266     1266           
Flag Coverage Δ
python 83.57% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../python/apache_beam/transforms/periodicsequence.py 98.38% <0.00%> (-1.62%) ⬇️
sdks/python/apache_beam/io/localfilesystem.py 90.97% <0.00%> (-0.76%) ⬇️
...hon/apache_beam/runners/worker/bundle_processor.py 93.54% <0.00%> (+0.12%) ⬆️
sdks/python/apache_beam/transforms/combiners.py 93.43% <0.00%> (+0.38%) ⬆️
...hon/apache_beam/runners/direct/test_stream_impl.py 94.02% <0.00%> (+0.74%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78ec29e...f1f478d. Read the comment docs.

@github-actions
Copy link
Copy Markdown
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @yeandy for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@github-actions
Copy link
Copy Markdown
Contributor

Reminder, please take a look at this pr: @yeandy

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 5, 2022

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @TheNeuralBit for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

@TheNeuralBit
Copy link
Copy Markdown
Member

@tvalentyn can you help here? I'm not sure how we want to handle acceptable version ranges for google-apitools

@tvalentyn
Copy link
Copy Markdown
Contributor

google-apitools is no longer maintained and eventually we should stop using it in Beam. Absent any need to switch to the latest version, so I'd prefer to skip this upgrade.

@tvalentyn
Copy link
Copy Markdown
Contributor

@dependabot ignore this dependency

@dependabot dependabot bot closed this Jul 11, 2022
@dependabot @github
Copy link
Copy Markdown
Contributor Author

dependabot bot commented on behalf of github Jul 11, 2022

OK, I won't notify you about google-apitools again, unless you re-open this PR or update it yourself. 😢

@dependabot dependabot bot deleted the dependabot/pip/sdks/python/google-apitools-gte-0.5.31-and-lt-0.5.33 branch July 11, 2022 16:43
@TheNeuralBit
Copy link
Copy Markdown
Member

Thanks @tvalentyn. It looks like #20147 is the relevant issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file Next Action: Reviewers python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants