Skip to content

Conversation

@kennknowles
Copy link
Member

The reverted change causes incorrect results in error cases in the ZetaSQL compliance tests.

This reverts commit 299be58.

The reverted change caused failure in ZetaSQL compliance testing, specifically for error cases.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

The reverted change causes incorrect results in error cases in the ZetaSQL
compliance tests.

This reverts commit 299be58.
@kennknowles
Copy link
Member Author

@pabloem @apilloud

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @lukecwik for label java.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Member

@apilloud apilloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennknowles
Copy link
Member Author

Run Java_IOs_Direct PreCommit

@kennknowles
Copy link
Member Author

Run Java_Pulsar_IO_Direct PreCommit

@kennknowles
Copy link
Member Author

Run Java_Examples_Dataflow PreCommit

@kennknowles kennknowles merged commit b2222b5 into apache:master Mar 16, 2023
@kennknowles kennknowles deleted the revert-zetasql-dlq branch March 16, 2023 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants