-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Update sphinx requirement from <2.0,>=1.5.2 to >=1.5.2,<7.0 in /sdks/python #26132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update sphinx requirement from <2.0,>=1.5.2 to >=1.5.2,<7.0 in /sdks/python #26132
Conversation
|
Assigning reviewers. If you would like to opt out of this review, comment R: @tvalentyn for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
This tooling is used to generate docs, which we do for releases. R: @jrmccluskey (next release manager). |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
|
actually, may be not worth merging before the release cut... @riteshghorse - would you mind taking a look if this upgrade 'just works' ? if so, it would likely apply to the next release |
Codecov Report
@@ Coverage Diff @@
## master #26132 +/- ##
==========================================
- Coverage 71.17% 71.16% -0.01%
==========================================
Files 787 787
Lines 103293 103311 +18
==========================================
+ Hits 73517 73522 +5
- Misses 28287 28300 +13
Partials 1489 1489
Flags with carried forward coverage won't be shown. Click here to find out more. see 8 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@dependabot rebase |
Updates the requirements on [sphinx](https://github.com/sphinx-doc/sphinx) to permit the latest version. - [Release notes](https://github.com/sphinx-doc/sphinx/releases) - [Changelog](https://github.com/sphinx-doc/sphinx/blob/master/CHANGES) - [Commits](sphinx-doc/sphinx@1.5.2...v6.1.3) --- updated-dependencies: - dependency-name: sphinx dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
121c449 to
6d99839
Compare
|
By 'just works' do you mean if the build completes successfully? |
|
Actually we can hold off this update for now. |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
|
@dependabot ignore this dependency |
|
OK, I won't notify you about sphinx again, unless you re-open this PR. 😢 |
Updates the requirements on sphinx to permit the latest version.
Release notes
Sourced from sphinx's releases.
Changelog
Sourced from sphinx's changelog.
... (truncated)
Commits
776d01eBump to 6.1.3 finala2e922aCHANGES for Sphinx 6.1.331162a9Handle exceptions forget_node_sourceandget_node_linedcb4429Restore Sphinx 5nodes.Elementcopying behaviour2a7c40dUndo parallel image changes7841d3dIgnore more checks in Ruff 0.0.214ddbc5b5Bump version393b408Bump to 6.1.2 finald8a5dd8Add note to CHANGES for PR 11100a1cd19eFix copying images under parallel execution (#11100)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)