Conversation
…the default jar. Signed-off-by: Jason Kuster <jasonkuster@google.com>
This reverts commit 9336230. It appears to break the BigQueryTornadoesIT.
…ext to what we actually need Remove unused pieces of DirectStepContext Revise StepContext javadoc Shorten excessive name in DirectExecutionContext Delete unused BaseStepContext Delete unused remnants in DirectExecutionContext Remove unused StepContext name methods Delete unused ExecutionContext Inline and delete BaseExecutionContext Remove writePCollectionViewData from the Beam codebase Implement StepContext directly in the DirectRunner Remove extraneous ExecutionContext parameter to BaseStepContext Move BaseStepContext to the top level Rename BaseExecutionContext.StepContext to BaseStepContext Remove StepContext.noteOutput Move StepContext to top level
This is to give a standard and obvious suffix for all our helper classes for translating to/from Runner API protos.
Also revise the Javadoc on MetricsContainers.
Assume Spanner database exists.
…anslators This closes #3310
Before, the config snapshot was not deserializable because there was no default constructor and read()/write() where not implemented. This also changes the compatibility-check logic to compare the class name of the Coder to avoid serializing the coder using Java Serialization.
Before, there was no call to setNextWatermarkTimer() in case the source had multiple Readers. This also adds a test for watermark emission to UnboundedSourceWrapperTest.
Author
|
R: @davorbonaci |
Author
|
@davorbonaci, could you merge this directly? I'll follow with another PR to solve the errors. |
…xecuting with the Fn API.
…xecuting with the Fn API. This closes #3312
Member
|
Sure -- merged (since this is a feature branch). Please fix it up sooner rather than later. |
Member
|
Merged; please close. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pull latest code from
masterbranch toDSL_SQLbranch.