Add JVM arguments to fix hadoop-format tests on JDK 17+#39283
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces configuration changes to the Hadoop IO module's build process to resolve test failures occurring on newer Java versions. By explicitly adding module exports and opens, the changes allow embedded dependencies like Cassandra and Elasticsearch to function correctly under the stricter encapsulation rules of JDK 17 and beyond. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request configures the Gradle build for the Hadoop Format IO SDK to support Java 17 or higher by allowing the security manager and adding JVM export and open arguments. The reviewer pointed out that unconditionally adding the --add-exports and --add-opens JVM arguments will cause test execution to fail on JDK 8, and suggested nesting these arguments inside the Java 17 conditional block.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| if (isJava17OrHigher) { | ||
| systemProperty 'java.security.manager', 'allow' | ||
| } | ||
| // Open and export modules for embedded Cassandra and Elasticsearch under Java 17+ | ||
| jvmArgs '--add-exports=java.base/sun.nio.ch=ALL-UNNAMED', | ||
| '--add-exports=java.rmi/sun.rmi.registry=ALL-UNNAMED', | ||
| '--add-exports=java.base/jdk.internal.misc=ALL-UNNAMED', | ||
| '--add-opens=java.base/sun.nio.ch=ALL-UNNAMED', | ||
| '--add-opens=java.base/java.lang=ALL-UNNAMED', | ||
| '--add-opens=java.base/java.util=ALL-UNNAMED', | ||
| '--add-opens=java.base/java.util.concurrent=ALL-UNNAMED', | ||
| '--add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED', | ||
| '--add-opens=java.base/java.io=ALL-UNNAMED', | ||
| '--add-opens=java.base/java.net=ALL-UNNAMED', | ||
| '--add-opens=java.base/java.nio=ALL-UNNAMED' | ||
| } |
There was a problem hiding this comment.
Unconditionally adding --add-exports and --add-opens JVM arguments will cause test execution to fail when running on JDK 8, as these options are not recognized by Java 8. These arguments should be nested inside the if (isJava17OrHigher) block so they are only applied when running on JDK 17 or higher.
if (isJava17OrHigher) {
systemProperty 'java.security.manager', 'allow'
// Open and export modules for embedded Cassandra and Elasticsearch under Java 17+
jvmArgs '--add-exports=java.base/sun.nio.ch=ALL-UNNAMED',
'--add-exports=java.rmi/sun.rmi.registry=ALL-UNNAMED',
'--add-exports=java.base/jdk.internal.misc=ALL-UNNAMED',
'--add-opens=java.base/sun.nio.ch=ALL-UNNAMED',
'--add-opens=java.base/java.lang=ALL-UNNAMED',
'--add-opens=java.base/java.util=ALL-UNNAMED',
'--add-opens=java.base/java.util.concurrent=ALL-UNNAMED',
'--add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED',
'--add-opens=java.base/java.io=ALL-UNNAMED',
'--add-opens=java.base/java.net=ALL-UNNAMED',
'--add-opens=java.base/java.nio=ALL-UNNAMED'
}
}
There was a problem hiding this comment.
based on
beam/sdks/java/io/cassandra/build.gradle
Line 80 in 3e7885d
|
R: @Abacn |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
2 participants
Trying this to fix https://github.com/apache/beam/actions/workflows/beam_PreCommit_Java_Hadoop_IO_Direct.yml
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.