Skip to content

Add JVM arguments to fix hadoop-format tests on JDK 17+ #39283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tvalentyn merged 1 commit into from
Jul 10, 2026
+21 −0
Merged

Add JVM arguments to fix hadoop-format tests on JDK 17+ #39283

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions sdks/java/io/hadoop-format/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,3 +202,24 @@ static def createTaskNames(Map<String, String> hadoopVersions, String suffix) {
.map{num -> "runHadoopFormatIO$num$suffix"}
.collect(Collectors.toList())
}

def testJavaVer = project.findProperty('testJavaVersion') ?: JavaVersion.current().getMajorVersion()
def isJava17OrHigher = testJavaVer.toInteger() >= 17

tasks.withType(Test).configureEach {
if (isJava17OrHigher) {
systemProperty 'java.security.manager', 'allow'
}
// Open and export modules for embedded Cassandra and Elasticsearch under Java 17+
jvmArgs '--add-exports=java.base/sun.nio.ch=ALL-UNNAMED',
'--add-exports=java.rmi/sun.rmi.registry=ALL-UNNAMED',
'--add-exports=java.base/jdk.internal.misc=ALL-UNNAMED',
'--add-opens=java.base/sun.nio.ch=ALL-UNNAMED',
'--add-opens=java.base/java.lang=ALL-UNNAMED',
'--add-opens=java.base/java.util=ALL-UNNAMED',
'--add-opens=java.base/java.util.concurrent=ALL-UNNAMED',
'--add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED',
'--add-opens=java.base/java.io=ALL-UNNAMED',
'--add-opens=java.base/java.net=ALL-UNNAMED',
'--add-opens=java.base/java.nio=ALL-UNNAMED'
}
Comment on lines +210 to +225

@gemini-code-assist gemini-code-assist Bot Jul 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Unconditionally adding --add-exports and --add-opens JVM arguments will cause test execution to fail when running on JDK 8, as these options are not recognized by Java 8. These arguments should be nested inside the if (isJava17OrHigher) block so they are only applied when running on JDK 17 or higher.

  if (isJava17OrHigher) {
    systemProperty 'java.security.manager', 'allow'
    // Open and export modules for embedded Cassandra and Elasticsearch under Java 17+
    jvmArgs '--add-exports=java.base/sun.nio.ch=ALL-UNNAMED',
            '--add-exports=java.rmi/sun.rmi.registry=ALL-UNNAMED',
            '--add-exports=java.base/jdk.internal.misc=ALL-UNNAMED',
            '--add-opens=java.base/sun.nio.ch=ALL-UNNAMED',
            '--add-opens=java.base/java.lang=ALL-UNNAMED',
            '--add-opens=java.base/java.util=ALL-UNNAMED',
            '--add-opens=java.base/java.util.concurrent=ALL-UNNAMED',
            '--add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED',
            '--add-opens=java.base/java.io=ALL-UNNAMED',
            '--add-opens=java.base/java.net=ALL-UNNAMED',
            '--add-opens=java.base/java.nio=ALL-UNNAMED'
  }
}

@tvalentyn tvalentyn Jul 10, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

based on

beam/sdks/java/io/cassandra/build.gradle

Line 80 in 3e7885d

// Open and export modules for embedded Cassandra under Java 17+

Loading