normalize KinesisIO - #39763
Conversation
|
Assigning reviewers: R: @tvalentyn for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Abacn
left a comment
There was a problem hiding this comment.
I understand KenisisIO generally needs an AWS project to test (in which Beam CI lacks), is there still a way to be able to test the yaml transform? cc: @derrickaw for inputs.
|
Hi @aIbrahiim, can you investigate setting up LocalStack container in sdks/python/apache_beam/yaml/integration_tests.py to step up a test for kinesis and also either create a kinesis yaml pipeline under yaml/tests (if localstack is lightweight) or put under extended_tests/data (if localstack is heavy)? Thanks. |
resolves: #28689
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.