Skip to content

ValueKind coder - #39989

Merged
ahmedabu98 merged 2 commits into
apache:masterfrom
ahmedabu98:valuekind-coder
Sep 3, 2026
Merged

ValueKind coder#39989
ahmedabu98 merged 2 commits into
apache:masterfrom
ahmedabu98:valuekind-coder

Conversation

@ahmedabu98

Copy link
Copy Markdown
Contributor

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@kennknowles kennknowles left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. This way it leverages the stability of the proto definition.

@codecov

codecov Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 61.90476% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.39%. Comparing base (b20e5fd) to head (091592f).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...ava/org/apache/beam/sdk/coders/ValueKindCoder.java 57.89% 6 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #39989      +/-   ##
============================================
+ Coverage     56.07%   58.39%   +2.31%     
- Complexity     2284    13555   +11271     
============================================
  Files          1120     2574    +1454     
  Lines        176677   268890   +92213     
  Branches       1475    11056    +9581     
============================================
+ Hits          99073   157020   +57947     
- Misses        75093   105909   +30816     
- Partials       2511     5961    +3450     
Flag Coverage Δ
java 64.57% <61.90%> (-11.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @kennknowles for label java.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@ahmedabu98
ahmedabu98 merged commit bddab86 into apache:master Sep 3, 2026
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants