Fix errorprone to version 2.3.1 - #6657
Conversation
youngoli
left a comment
youngoli
left a comment
There was a problem hiding this comment.
I have one question, but I'm approving this because I've confirmed it works and we should merge in a fix ASAP to unblock people.
| // Enable errorprone static analysis | ||
| project.apply plugin: 'net.ltgt.errorprone' | ||
|
|
||
| project.configurations.errorprone { resolutionStrategy.force 'com.google.errorprone:error_prone_core:2.3.1' } |
There was a problem hiding this comment.
In the description for the plugin (https://github.com/tbroyer/gradle-errorprone-plugin) it says to simply include errorprone as a dependency, like so:
dependencies {
errorprone("com.google.errorprone:error_prone_core:$errorproneVersion")
}
Can we do it that way? Or are we forced to do it this way because the errorprone plugin is an older version than the one in the link?
There was a problem hiding this comment.
It needs to be after the plugin is applied
There was a problem hiding this comment.
It's because of how we apply the plugin and other plugins in our own plugin
There was a problem hiding this comment.
Ah yes, the fact that we cannot specify the dependency is because the old plugin we use doesn't work that way
|
Run Website_Stage_GCS PreCommit |
|
Seems website staging is perma-red. Definitely merge if Java goes green. |
|
Run Website_Stage_GCS PreCommit |
|
LGTM No need to block on website pre-commit. They should be fixed here, but it might require merging those changes into this PR first. |
|
My understanding was that running precommits would rebase on top of master, we'll find out |
|
Nope it didn't :) |
4 participants
Please add a meaningful description for your change here
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.It will help us expedite review of your Pull Request if you tag someone (e.g.
@username) to look at it.Post-Commit Tests Status (on master branch)