Remove the mvn related stuff from camel-k#507
Closed
WillemJiang wants to merge 1 commit intoapache:masterfrom
Closed
Remove the mvn related stuff from camel-k#507WillemJiang wants to merge 1 commit intoapache:masterfrom
WillemJiang wants to merge 1 commit intoapache:masterfrom
Conversation
oscerd
approved these changes
Feb 28, 2019
Contributor
|
There is still a script using the maven stuff. @lburgazzoli is it something we can remove or we need it for the build? |
Contributor
|
we need it
On Thu, 28 Feb 2019 at 09:00, Andrea Cosentino ***@***.***> wrote:
There is still a script using the maven stuff. @lburgazzoli
<https://github.com/lburgazzoli> is it something we can remove or we need
it for the build?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#507 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AByEhT_g5n6gUWm7aVFIDVMXc1O1_vHeks5vR4y0gaJpZM4bWNZZ>
.
--
--
Luca Burgazzoli
|
Contributor
|
Ok, so I think this can be closed. |
Member
Author
|
The CI build error explain it.
It looks like we need package the camel-k-runtime dependencies into the image. |
Contributor
|
yes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As we move the java related code to camel-k-runtime, we don't need mvnw related stuff in camel-k repo any more.