fix(knative): remove Broker type limitation#5580
Closed
squakez wants to merge 1 commit intoapache:mainfrom
Closed
Conversation
Contributor
|
I think we are mixing up things here a bit. The type information is not the broker name but the cloud event type set as a field on the cloud event message. We should not set this to the broker name using |
christophd
requested changes
Jun 4, 2024
Contributor
christophd
left a comment
christophd
left a comment
There was a problem hiding this comment.
I think this is a misunderstanding. The mentioned type limitation in the issue is not the broker name but the cloud event type applied as a filter on the Trigger created by Camel K.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #5529
Release Note