Skip to content

fix(#2321): maven repo and service account encapsulation#5716

Closed
jonomorris wants to merge 4 commits into
apache:mainfrom
jonomorris:fix/2321
Closed

fix(#2321): maven repo and service account encapsulation#5716
jonomorris wants to merge 4 commits into
apache:mainfrom
jonomorris:fix/2321

Conversation

@jonomorris
Copy link
Copy Markdown
Contributor

Fixes #2321

Move the .spec.repositories field (Maven repositories) into the builder trait, and the .spec.serviceAccountName field into the pod trait in order to better encapsulate responsibility.

Release Note

NONE

Copy link
Copy Markdown
Contributor

@squakez squakez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work. It is helping to narrow certain technical aspects that were not clear from the issue definition.

  1. First of all, we cannot remove any parameter from the API without a proper deprecation notice time. For the time being, any old configuration must coexist with the new one and the old one has to be marked in code as deprecated and possibly added a warning to log and Integration condition types.
  2. You development shows that the ServiceAccount really belong to the Integration as it is shared among too many traits. It does not make sense to check the presence of another trait as it increase the dependency coupling between traits, so it must be probably stay as it is.

@jonomorris
Copy link
Copy Markdown
Contributor Author

Np, I'll revert the change to ServiceAccount and reinstate the original spec.repositories with a deprecation notice if that will work.

@squakez
Copy link
Copy Markdown
Contributor

squakez commented Jul 29, 2024

Np, I'll revert the change to ServiceAccount and reinstate the original spec.repositories with a deprecation notice if that will work.

Perfect, thanks!

@jonomorris jonomorris closed this Jul 30, 2024
@jonomorris jonomorris deleted the fix/2321 branch July 31, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Trait] maven repo and service account encapsulation

2 participants