fix(#2321): maven repo and service account encapsulation#5716
Closed
jonomorris wants to merge 4 commits into
Closed
fix(#2321): maven repo and service account encapsulation#5716jonomorris wants to merge 4 commits into
jonomorris wants to merge 4 commits into
Conversation
squakez
reviewed
Jul 29, 2024
Contributor
squakez
left a comment
There was a problem hiding this comment.
Thanks for the work. It is helping to narrow certain technical aspects that were not clear from the issue definition.
- First of all, we cannot remove any parameter from the API without a proper deprecation notice time. For the time being, any old configuration must coexist with the new one and the old one has to be marked in code as deprecated and possibly added a warning to log and Integration condition types.
- You development shows that the ServiceAccount really belong to the Integration as it is shared among too many traits. It does not make sense to check the presence of another trait as it increase the dependency coupling between traits, so it must be probably stay as it is.
Contributor
Author
|
Np, I'll revert the change to ServiceAccount and reinstate the original |
Contributor
Perfect, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2321
Move the
.spec.repositoriesfield (Maven repositories) into the builder trait, and the.spec.serviceAccountNamefield into the pod trait in order to better encapsulate responsibility.Release Note