Skip to content

Conversation

@pkalsi97
Copy link
Contributor

Changes:

  • Added deprecation warning comment and +camel-k:deprecated=2.9.0 annotation
  • Added TraitCondition to warn users when the trait is enabled
  • Updated tests to expect deprecation condition and added TestTelemetryTraitDeprecationWarning
  • Auto-generated deprecation badge via gen_doc.sh
Migration example:
  Before: --trait telemetry.endpoint=http://jaeger:4317
  After:  -p quarkus.otel.exporter.otlp.traces.endpoint=http://jaeger:4317

Closes #6314

@pkalsi97 pkalsi97 changed the title chore(trait): deprecate telemetry trait in favor of properties configuration chore(trait): deprecate telemetry trait in favour of properties configuration Dec 12, 2025
Copy link
Contributor

@squakez squakez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. Please, have a look at the telemetry e2e tests as well, as we want to use the new properties instead of the now-deprecated trait. If you can't work on it now, we can create a follow up issue.

@pkalsi97
Copy link
Contributor Author

@squakez I can work on this here itself, I'll update the test to use the new properties in some time.

@pkalsi97
Copy link
Contributor Author

@squakez I've added a follow-up commit to update the e2e telemetry tests.

I am not sure about it. can you review it and guide me ? --dependency camel:opentelemetry is needed since the trait was adding this via the capability. Should the migration docs mention this? or I am not thinking it correctly?

@squakez
Copy link
Contributor

squakez commented Dec 13, 2025

@squakez I've added a follow-up commit to update the e2e telemetry tests.

I am not sure about it. can you review it and guide me ? --dependency camel:opentelemetry is needed since the trait was adding this via the capability. Should the migration docs mention this? or I am not thinking it correctly?

Yes. From now on the user has to include the dependency. You can add a note to the migration docs, thanks!

@github-actions
Copy link
Contributor

⚠️ Unit test coverage report - coverage decreased from 51.6% to 51.5% (-0.1%)

@pkalsi97
Copy link
Contributor Author

@squakez I have added it now. Please run the CI again. Thanks!

@squakez squakez merged commit d08cfdc into apache:main Dec 14, 2025
10 checks passed
@pkalsi97 pkalsi97 deleted the chore/6314 branch December 14, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecate telemetry trait

2 participants