-
Notifications
You must be signed in to change notification settings - Fork 366
fix(jvm): change caCert params from secret refs to file paths #6427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
✔️ Unit test coverage report - coverage increased from 59.8% to 61.1% (+1.3%) |
squakez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work. And yes, it is better when done with less code!
|
@squakez yup. I definitely think I need to study the existing traits better. I wasn't able to think about this solution in the first attempt. |
You're doing a great work, and for sure we're here to drive the newer contributors in the right direction :) |
|
✔️ Unit test coverage report - coverage increased from 59.2% to 61.1% (+1.9%) |
|
@squakez I am a bit out and won't be able to take a look at the ci failure till tomorrow. |
No worries. It does not seem to be related to this PR. And, in general, we have no rush to have things sorted immediately. |
Changes JVM trait
caCertandcaCertPasswordparameters from secret references (secret:name/key) to file paths.Users can now mount secrets via the mount trait and provide file paths to the JVM trait:
Closes #6425
Original Issue #2820
Follows up to #6416