build: repopulate TypeMeta after client.Get to avoid event recorder nil deref#6601
Closed
SAY-5 wants to merge 1 commit into
Closed
build: repopulate TypeMeta after client.Get to avoid event recorder nil deref#6601SAY-5 wants to merge 1 commit into
SAY-5 wants to merge 1 commit into
Conversation
…il deref Signed-off-by: SAY-5 <say.apm35@gmail.com>
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6587.
After PR #6492 migrated the build controller from
record.EventRecordertoevents.EventRecorder, every event publish went throughreference.GetReference(scheme, obj)which callsobj.GetObjectKind(). controller-runtime stripsTypeMetafrom objects returned byclient.Get(kubernetes-sigs/controller-runtime#1735), soGetObjectKind()nil-derefs and the build controller panics on every reconcile.Repopulate
TypeMetaimmediately afterclient.Getreturns. The same pattern likely affects the pipe, integration, integrationkit, integrationplatform, and catalog controllers (all migrated toevents.EventRecorder); happy to send a sibling PR if you'd like the sweep, but filing Build alone first per the issue scope.